Skip to content

Conversation

katarzyna-z
Copy link
Contributor

  • Corrected information about perf metrics
  • Add information about build flags required for metrics

Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
Signed-off-by: Katarzyna Kujawa <katarzyna.kujawa@intel.com>
@katarzyna-z
Copy link
Contributor Author

/retest

@dashpole
Copy link
Collaborator

dashpole commented Jul 6, 2020

Looks like the divider is missing between container_perf_events_total and container_perf_metric_scaling_ratio, and the divider above libpfm for container_perf_events_total.

@katarzyna-z
Copy link
Contributor Author

I don't see that... I see 5 dividers in lines with container_perf_events_total and 5 dividers in line with container_perf_metric_scaling_ratio

@dashpole
Copy link
Collaborator

dashpole commented Jul 7, 2020

I only see it when displaying the rich diff... not actually sure why it happens. We can fix it in a follow-up if needed.

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 7fe7144 into google:master Jul 7, 2020
@dashpole
Copy link
Collaborator

dashpole commented Jul 7, 2020

huh, I don't see the problem anymore in the actual page: https://github.com/google/cadvisor/blob/master/docs/storage/prometheus.md

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants