Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Resctrl metrics. #2563

Merged
merged 11 commits into from
Jun 19, 2020
Merged

Add Resctrl metrics. #2563

merged 11 commits into from
Jun 19, 2020

Conversation

Creatone
Copy link
Collaborator

This PR provides support for Resource Control statistics.

@k8s-ci-robot
Copy link
Collaborator

Hi @Creatone. Thanks for your PR.

I'm waiting for a google member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Creatone Creatone force-pushed the creatone/resctrl branch from 1411331 to d776a7c Compare May 29, 2020 14:55
Add Resctrl metrics.
f892833 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
@Creatone Creatone force-pushed the creatone/resctrl branch from d776a7c to f892833 Compare May 29, 2020 14:57
dashpole
dashpole reviewed Jun 1, 2020
View reviewed changes
info/v1/container.go Outdated Show resolved Hide resolved
info/v1/container.go Show resolved Hide resolved
info/v1/container.go Outdated Show resolved Hide resolved
metrics/prometheus.go Outdated Show resolved Hide resolved
metrics/prometheus.go Outdated Show resolved Hide resolved
metrics/prometheus.go Outdated Show resolved Hide resolved
metrics/prometheus.go Show resolved Hide resolved
Paweł Szulik added 4 commits June 2, 2020 11:13
Add comment with link.
40977dc 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
Better names for Resctrl metrics.
7a8ccb4 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
Fix prometheus testdata.
69dcc21 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
Change label.
17964c7 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
katarzyna-z
katarzyna-z reviewed Jun 4, 2020
View reviewed changes
info/v1/container.go Outdated Show resolved Hide resolved
katarzyna-z
katarzyna-z reviewed Jun 4, 2020
View reviewed changes
info/v1/container.go Outdated Show resolved Hide resolved
katarzyna-z
katarzyna-z reviewed Jun 4, 2020
View reviewed changes
info/v2/container.go Outdated Show resolved Hide resolved
katarzyna-z
katarzyna-z reviewed Jun 4, 2020
View reviewed changes
info/v2/conversion.go Outdated Show resolved Hide resolved
Paweł Szulik added 3 commits June 8, 2020 10:15
Merge branch 'master' of github.com:google/cadvisor into creatone/res…
17e4b05 
…ctrl
Some fixes.
0bc49d8 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
Delete dots.
8540ee3 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
@dashpole
Copy link
Collaborator

dashpole commented Jun 9, 2020

/ok-to-test

dashpole
dashpole reviewed Jun 9, 2020
View reviewed changes
metrics/prometheus.go Outdated Show resolved Hide resolved
Change metric names.
44fb05d 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
@katarzyna-z
Copy link
Collaborator

please add new metrics to this table https://github.com/google/cadvisor/blob/master/docs/storage/prometheus.md#prometheus-container-metrics

Paweł Szulik added 2 commits June 16, 2020 15:53
Change structs names.
1470280 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
Add docs.
b61cfda 
Signed-off-by: Paweł Szulik <pawel.szulik@intel.com>
dashpole
dashpole approved these changes Jun 19, 2020
View reviewed changes
Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 0ac6b77 into google:master Jun 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@katarzyna-z katarzyna-z katarzyna-z left review comments

@dashpole dashpole dashpole approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Creatone @k8s-ci-robot @dashpole @katarzyna-z