Remove CloudProvider SDK dependencies #2213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 tasks
|
/retest |
|
This will mean that the cadvisor v1 machine info returned by the kubelet's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change CloudInfo to use a registration pattern, making the dependencies on the cloud provider SDKs optional. The CloudProviders are registered in the main cadvisor binary, so for non-library usages there are no changes.
For Kubernetes, I verified that the info provided by CloudInfo is unused by removing it and confirming everything still builds: tallclair/kubernetes@9274b43 (the only reference in Kubernetes was in the cadvisor fake)