Reorganize code to allow conditional enablement of runtimes #2209
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dims
force-pushed
the
conditional-registration-of-runtimes
branch
5 times, most recently
from
1403621 to
3a68712
Compare
|
Let me know when this is ready for review |
dims
changed the title
dims
force-pushed
the
conditional-registration-of-runtimes
branch
from
3a68712 to
f6e51e8
Compare
|
@dashpole this is ready now (just rebased) |
|
cc @tallclair |
|
This is awesome (I haven't thoroughly reviewed it yet though) What is the plan for integrating this into Kubernetes though? BTW, there are still a bunch of docker dependencies, but those probably deserve to be addressed independently. |
dashpole
reviewed
Apr 4, 2019
dims
force-pushed
the
conditional-registration-of-runtimes
branch
from
f6e51e8 to
c2870da
Compare
|
@tallclair yep! wanted to peel off some of the leaves first (like mesos) In kubernetes, we will import only the items corresponding to the CRI(s) that we support. |
dashpole
reviewed
Apr 5, 2019
Change-Id: I76583736d7ad39190a1a2bca820d4e957caadc84
dims
force-pushed
the
conditional-registration-of-runtimes
branch
from
c2870da to
40e6acb
Compare
dashpole
approved these changes
Apr 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: I76583736d7ad39190a1a2bca820d4e957caadc84