Skip to content

Conversation

@haircommander
Copy link
Contributor

Before, making a ContainerInfo request returned an uninformative message about failing to decode json.
Fix this by catching response codes that aren't 200, and return a more informative message.

Signed-off-by: Peter Hunt pehunt@redhat.com

Before, making a ContainerInfo request returned an uninformative message about failing to decode json.
Fix this by catching response codes that aren't 200, and return a more informative message.

Signed-off-by: Peter Hunt <pehunt@redhat.com>
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Collaborator

Hi @haircommander. Thanks for your PR.

I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@haircommander
Copy link
Contributor Author

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@haircommander
Copy link
Contributor Author

@mrunalp PTAL

@dashpole
Copy link
Collaborator

/ok-to-test

@dashpole
Copy link
Collaborator

This lgtm. Ill let @mrunalp take a look before I merge it.

Copy link
Contributor

@mrunalp mrunalp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. Thanks!

@dashpole dashpole merged commit 50076da into google:master Mar 22, 2019
haircommander pushed a commit to haircommander/cadvisor that referenced this pull request Mar 27, 2019
container: crio: Return more informative error
haircommander pushed a commit to haircommander/cadvisor that referenced this pull request Mar 27, 2019
container/crio Return more informative error on failed http request
haircommander pushed a commit to haircommander/cadvisor that referenced this pull request Mar 27, 2019
container/crio Return more informative error on failed http request

Signed-off-by: Peter Hunt <pehunt@redhat.com>
sjenning added a commit to openshift/google-cadvisor that referenced this pull request Mar 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants