-
Notifications
You must be signed in to change notification settings - Fork 2.4k
container: crio: Return more informative error #2201
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Before, making a ContainerInfo request returned an uninformative message about failing to decode json. Fix this by catching response codes that aren't 200, and return a more informative message. Signed-off-by: Peter Hunt <pehunt@redhat.com>
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
Hi @haircommander. Thanks for your PR. I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
|
@mrunalp PTAL |
|
/ok-to-test |
|
This lgtm. Ill let @mrunalp take a look before I merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. Thanks!
container: crio: Return more informative error
container/crio Return more informative error on failed http request
container/crio Return more informative error on failed http request Signed-off-by: Peter Hunt <pehunt@redhat.com>
UPSTREAM: google/cadvisor: google#2201:
Before, making a ContainerInfo request returned an uninformative message about failing to decode json.
Fix this by catching response codes that aren't 200, and return a more informative message.
Signed-off-by: Peter Hunt pehunt@redhat.com