Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change log level to warning instead of error when cgroups file read f… #2167

Merged
merged 1 commit into from
Feb 8, 2019

Conversation

nekop
Copy link
Contributor

@nekop nekop commented Feb 7, 2019

…ailed.

Because cgroups file may not exist at the timing of the read, it's better not to use error level.

…ailed.

Because cgroups file may not exist at the timing of the read, it's better not to use error level.
@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@k8s-ci-robot
Copy link
Collaborator

Hi @nekop. Thanks for your PR.

I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@nekop
Copy link
Contributor Author

nekop commented Feb 7, 2019

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@dashpole
Copy link
Collaborator

dashpole commented Feb 7, 2019

/ok-to-test

@dashpole
Copy link
Collaborator

dashpole commented Feb 7, 2019

Because cgroups file may not exist at the timing of the read

Can you describe such a case?

@nekop
Copy link
Contributor Author

nekop commented Feb 7, 2019

Can you describe such a case?

When a container and the cgroups removed before read the file. This error log appears multiple times every day in healthy k8s clusters.

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 634fb4b into google:master Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants