Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Amazon VM detection on EC2 Nitro generation. #2156

Merged
merged 1 commit into from
Feb 13, 2019

Conversation

dtrejod
Copy link
Contributor

@dtrejod dtrejod commented Jan 28, 2019

Adds a second check for Amazon to cover Ec2 Gen5 Instances where DMI values have changed.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@k8s-ci-robot
Copy link
Collaborator

Hi @dtrejod. Thanks for your PR.

I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dashpole
Copy link
Collaborator

This looks reasonable. Do we want to handle cases where one of the files isn't found?

@dtrejod dtrejod force-pushed the dt/ec2-gen5-detection branch from 387faba to fe06d6e Compare January 29, 2019 17:02
@dtrejod
Copy link
Contributor Author

dtrejod commented Jan 29, 2019

Agreed. I updated the original commit.

@dashpole
Copy link
Collaborator

/ok-to-test

Ill take another look after you resolve the CLA

@dtrejod
Copy link
Contributor Author

dtrejod commented Jan 29, 2019

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@dtrejod
Copy link
Contributor Author

dtrejod commented Feb 13, 2019

@dashpole Any blockers to accepting this PR?

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit cd92744 into google:master Feb 13, 2019
@dashpole
Copy link
Collaborator

nope, just fell off my radar. Thanks for the contribution and the ping!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants