Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix timestamp error for container_last_seen #2135

Merged
merged 1 commit into from
Jan 9, 2019
Merged

fix timestamp error for container_last_seen #2135

merged 1 commit into from
Jan 9, 2019

Conversation

Betula-L
Copy link
Contributor

Since PR #2124, prometheus can not scrape cAdvisor /metrics now.

Issue #2133 report the bug.

I don't know this PR is an appropriate way to fix that bug.

@k8s-ci-robot
Copy link
Collaborator

Hi @Betula-L. Thanks for your PR.

I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@Betula-L Betula-L mentioned this pull request Dec 29, 2018
Closed
@dashpole
Copy link
Collaborator

dashpole commented Jan 2, 2019

/ok-to-test

@dashpole
Copy link
Collaborator

dashpole commented Jan 2, 2019

I think this is the right thing to do, even if it looks a little funky

@Betula-L
Copy link
Contributor Author

Betula-L commented Jan 3, 2019

/retest

@Betula-L
Copy link
Contributor Author

Betula-L commented Jan 3, 2019

I can't understand why this pr tested failed.

@dashpole
Copy link
Collaborator

dashpole commented Jan 3, 2019

its probably a test-infra issue. Ill take a look today

@dashpole dashpole closed this Jan 3, 2019
@dashpole dashpole reopened this Jan 3, 2019
@dashpole
Copy link
Collaborator

dashpole commented Jan 3, 2019

wrong button

@dashpole
Copy link
Collaborator

dashpole commented Jan 3, 2019

Happy 2019! Please rebase on top of #2137, and that should fix it.

@Betula-L Betula-L force-pushed the fix_timestamp_error branch from a7e5a89 to e88534c Compare January 4, 2019 02:13
dashpole
dashpole reviewed Jan 9, 2019
View reviewed changes
Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

dashpole
dashpole approved these changes Jan 9, 2019
View reviewed changes
Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 45d3b77 into google:master Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dashpole dashpole dashpole approved these changes

Assignees
No one assigned
Labels
ok-to-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Betula-L @k8s-ci-robot @dashpole