Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix if no NUMA support in kernel #2127

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Conversation

lubinszARM
Copy link
Contributor

After testing for edge devices with minimal kernel configuration(without numa),
I think we should report coreId = threadId/nodeId=0 if found error.

Signed-off-by: Bin Lu bin.lu@arm.com

@k8s-ci-robot
Copy link
Collaborator

Hi @lubinszARM. Thanks for your PR.

I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: Bin Lu <bin.lu@arm.com>
@dashpole
Copy link
Collaborator

/ok-to-test
What is the effect of reporting coreId = threadId/nodeId=0? Can you expand on that a little bit?

@lubinszARM
Copy link
Contributor Author

/ok-to-test
What is the effect of reporting coreId = threadId/nodeId=0? Can you expand on that a little bit?

Just same with the topology of 'no numa'.

On a non-numa board, coreId = threadId = physical-cpu-id. And only contains node 0.

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 864d279 into google:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants