Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tcp6 and udp6 metrics are published via Prometheus #2102

Merged
merged 2 commits into from
Dec 7, 2018

Conversation

hangongithub
Copy link
Contributor

Fixes #2066

This is a duplicate of: #2084

It somehow got closed when I updated my fork. Sorry about that.

This commit addresses the comments made in the review of the previous pull request.

Thanks again.

@k8s-ci-robot
Copy link
Collaborator

Hi @hangongithub. Thanks for your PR.

I'm waiting for a google or kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dashpole
Copy link
Collaborator

/ok-to-test

@hangongithub
Copy link
Contributor Author

Can I get a quick review on this? Thanks!

Copy link
Collaborator

@dashpole dashpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dashpole dashpole merged commit 70b83b9 into google:master Dec 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tcp6 metrics not available via Prometheus output
4 participants