-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc about error `Privileged mode is incompatible with user namespaces… #1582
Conversation
Hi @QianJin2013. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
@k8s-bot ok to test |
@jjqq2013 would you mind moving this to running.md? This is more specific information than I would like to include in the README. Thanks! |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@googlebot I signed it! |
@dashpole ok, moved to running.cmd |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
minor nits
docs/running.md
Outdated
@@ -18,6 +18,9 @@ sudo docker run \ | |||
|
|||
cAdvisor is now running (in the background) on `http://localhost:8080/`. The setup includes directories with Docker state cAdvisor needs to observe. | |||
|
|||
**Note**: If you're running docker daemon with user namespace enabled, the above command will run into |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nits
-the above command will emit the following error ...
-move to avoid it... to a new sentence
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cAdvisor command itself does not show error to user, it just failed to list all containers in its web UI, shows an error "Can not connect to docker daemon".
7b70634
to
9756c1d
Compare
Note: cAdvisor command itself does not show error to user, it just fails to list all containers in its web UI, shows an error "Can not connect to docker daemon". See screenshot: And this is how i rua my docker daemon with user namespace enabled.( in docker-machine on Mac OS X)
|
@jjqq2013 git doesnt seem to think you authored your commits. The icon next to the commit is not yours: https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user |
@dashpole sorry i used another email to commit, now i have added the email to github account settings. It seems now the author icon in my commit correctly show my avatar. |
CLAs look good, thanks! |
…` and solution `--userns=host`
Hi, i have my docker daemon run with user namespace enabled(All users in containers will be mapped to sub user of specified external user, see Starting the daemon with user namespaces enabled),
In this case, cadvisor can not list containers in manage web pages without explicit errors, it's confusing for users.
I know the reason is caused by the docker run
Privileged mode is incompatible with user namespaces
, so i added a statement in README.md.hope helpful.