Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc about error `Privileged mode is incompatible with user namespaces… #1582

Merged
merged 1 commit into from
Mar 20, 2017

Conversation

jjqq2013
Copy link
Contributor

@jjqq2013 jjqq2013 commented Jan 30, 2017

Hi, i have my docker daemon run with user namespace enabled(All users in containers will be mapped to sub user of specified external user, see Starting the daemon with user namespaces enabled),

In this case, cadvisor can not list containers in manage web pages without explicit errors, it's confusing for users.

I know the reason is caused by the docker run Privileged mode is incompatible with user namespaces , so i added a statement in README.md.

hope helpful.

@k8s-ci-robot
Copy link
Collaborator

Hi @QianJin2013. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@dashpole
Copy link
Collaborator

@k8s-bot ok to test

@dashpole
Copy link
Collaborator

dashpole commented Mar 15, 2017

@jjqq2013 would you mind moving this to running.md? This is more specific information than I would like to include in the README. Thanks!

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@jjqq2013
Copy link
Contributor Author

@googlebot I signed it!

@jjqq2013
Copy link
Contributor Author

@dashpole ok, moved to running.cmd

Copy link

@cmluciano cmluciano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nits

docs/running.md Outdated
@@ -18,6 +18,9 @@ sudo docker run \

cAdvisor is now running (in the background) on `http://localhost:8080/`. The setup includes directories with Docker state cAdvisor needs to observe.

**Note**: If you're running docker daemon with user namespace enabled, the above command will run into

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nits

-the above command will emit the following error ...
-move to avoid it... to a new sentence

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cAdvisor command itself does not show error to user, it just failed to list all containers in its web UI, shows an error "Can not connect to docker daemon".

@jjqq2013 jjqq2013 force-pushed the master branch 2 times, most recently from 7b70634 to 9756c1d Compare March 17, 2017 04:48
@jjqq2013
Copy link
Contributor Author

jjqq2013 commented Mar 17, 2017

Note: cAdvisor command itself does not show error to user, it just fails to list all containers in its web UI, shows an error "Can not connect to docker daemon".

See screenshot:

2017-03-17 13 08 31
2017-03-17 13 08 40

And this is how i rua my docker daemon with user namespace enabled.( in docker-machine on Mac OS X)

q@mac$ docker-machine ssh default

docker@default:~$ cat /etc/subuid 
dockremap:165536:65536

docker@default:~$ cat /etc/subgid 
dockremap:165536:65536

docker@default:~$ cat /etc/docker/daemon.json
{
  "userns-remap": "default"
}

docker@default:~$ sudo adduser --system dockremap
adduser: user 'dockremap' in use

docker@default:~$ exit

q@mac$ docker-machine restart default

@dashpole
Copy link
Collaborator

@jjqq2013 git doesnt seem to think you authored your commits. The icon next to the commit is not yours: https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/#commits-are-not-linked-to-any-user

@jjqq2013
Copy link
Contributor Author

@dashpole sorry i used another email to commit, now i have added the email to github account settings. It seems now the author icon in my commit correctly show my avatar.

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@dashpole dashpole merged commit bd72ac3 into google:master Mar 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants