Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mention another prometheus example using Grafana #1561

Merged
merged 2 commits into from
Jan 4, 2017

Conversation

bamarni
Copy link
Contributor

@bamarni bamarni commented Dec 21, 2016

The GUI part of the blog post example seems not much relevant anymore, there are some nice starter projects from @vegasbrianc that could be interesting to mention here.

@k8s-ci-robot
Copy link
Collaborator

Hi @bamarni. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with @k8s-bot ok to test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

If you have questions or suggestions related to this bot's behavior, please file an issue against the kubernetes/test-infra repository.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@bamarni
Copy link
Contributor Author

bamarni commented Dec 21, 2016

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@timstclair
Copy link
Contributor

Thanks!

@timstclair timstclair merged commit e2b87c8 into google:master Jan 4, 2017
andyxning pushed a commit to andyxning/cadvisor that referenced this pull request Jan 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants