Optimize TimedStore to avoid sort on every data add #1242
Conversation
| if len(self.buffer) == 0 || !timestamp.Before(self.buffer[len(self.buffer)-1].timestamp) { | ||
| self.buffer = append(self.buffer, data) | ||
| } else { | ||
| // Data is out of order; insert it in the correct position. |
There was a problem hiding this comment.
What causes this to happen?
There was a problem hiding this comment.
Creation events for containers that were running before cAdvisor started.
There was a problem hiding this comment.
Can we only do this once when starting & remove the need for this check when running normally?
There was a problem hiding this comment.
I'd rather not. I'm not positive there aren't any other times that events could arrive out of order, and I think the "common case" check makes the cost of this very low.
|
Reassigning to Vish - I'd like to get this in to k8s v1.3. |
|
@k8s-bot test this |
|
Sorry this slipped off my radar. LGTM. |
|
Thanks! I had heard a rumor you weren't working on cAdvisor anymore. |
|
@timstclair Rumours... I'm still around, just not contributing as much as I'd like to be able to right now. |
No description provided.