-
Notifications
You must be signed in to change notification settings - Fork 2.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add docs about using elasticsearch as a storage driver #1241
Conversation
Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test". This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry. Otherwise, if this message is too spammy, please complain to ixdy. |
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
@@ -0,0 +1,20 @@ | |||
# Exporting cAdvisor Stats to Elasticsearch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Capitalize the "search" in ElasticSearch, same below.
Thanks! I've been meaning to separate the storage documentation from the main readme, but this is ok for now. |
ok to test |
I signed it! |
CLAs look good, thanks! |
``` | ||
# ElasticSearch type name. By default it's "stats". | ||
-storage_driver_es_type="stats" | ||
# ElasticSearch uses a sniffing process to find all nodes of your cluster by default, automatically. False by default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you reword this to something like, ElasticSearch can use a sniffing process to find all nodes of your cluster automatically. False by default.
One last comment, then LGTM. |
done. rebased it |
Thanks! LGTM |
It's strange that there is not docs about ES storage driver. It would be useful for me.