Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add docs about using elasticsearch as a storage driver #1241

Merged
merged 1 commit into from
Apr 26, 2016

Conversation

nik-kor
Copy link
Contributor

@nik-kor nik-kor commented Apr 25, 2016

It's strange that there is not docs about ES storage driver. It would be useful for me.

@k8s-bot
Copy link
Collaborator

k8s-bot commented Apr 25, 2016

Can one of the admins verify that this patch is reasonable to test? If so, please reply "ok to test".
(Note: "add to whitelist" is no longer supported. Please update configurations in hack/jenkins/job-configs/kubernetes-jenkins-pull/ instead.)

This message may repeat a few times in short succession due to jenkinsci/ghprb-plugin#292. Sorry.

Otherwise, if this message is too spammy, please complain to ixdy.

@googlebot
Copy link
Collaborator

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@@ -0,0 +1,20 @@
# Exporting cAdvisor Stats to Elasticsearch
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capitalize the "search" in ElasticSearch, same below.

@timstclair
Copy link
Contributor

Thanks! I've been meaning to separate the storage documentation from the main readme, but this is ok for now.

@timstclair
Copy link
Contributor

ok to test

@k8s-bot
Copy link
Collaborator

k8s-bot commented Apr 25, 2016

Jenkins GCE e2e

Build/test passed for commit 20f40eb.

@nik-kor
Copy link
Contributor Author

nik-kor commented Apr 25, 2016

I signed it!

@googlebot
Copy link
Collaborator

CLAs look good, thanks!

@k8s-bot
Copy link
Collaborator

k8s-bot commented Apr 25, 2016

Jenkins GCE e2e

Build/test passed for commit 82c690c.

```
# ElasticSearch type name. By default it's "stats".
-storage_driver_es_type="stats"
# ElasticSearch uses a sniffing process to find all nodes of your cluster by default, automatically. False by default.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you reword this to something like, ElasticSearch can use a sniffing process to find all nodes of your cluster automatically. False by default.

@timstclair
Copy link
Contributor

One last comment, then LGTM.

@nik-kor
Copy link
Contributor Author

nik-kor commented Apr 26, 2016

done. rebased it

@k8s-bot
Copy link
Collaborator

k8s-bot commented Apr 26, 2016

Jenkins GCE e2e

Build/test passed for commit f2beaa5.

@timstclair
Copy link
Contributor

Thanks! LGTM

@timstclair timstclair merged commit 0ac3342 into google:master Apr 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants