Dont block on grpc if nothing is listeing on rkt api service port #1218
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,6 +38,13 @@ var ( | |||
|
|
|||
| func Client() (rktapi.PublicAPIClient, error) { | |||
| once.Do(func() { | |||
| _, err := net.Dial("tcp", "localhost:15441") | |||
There was a problem hiding this comment.
Use defaultRktAPIServiceAddr here
There was a problem hiding this comment.
I think you should use DialTimeout with a reasonable value
There was a problem hiding this comment.
The connection should be closed
|
Thanks for fixing this! |
| @@ -38,17 +38,19 @@ var ( | |||
|
|
|||
| func Client() (rktapi.PublicAPIClient, error) { | |||
| once.Do(func() { | |||
| _, err := net.Dial("tcp", "localhost:15441") | |||
| conn, err := net.DialTimeout("tcp", defaultRktAPIServiceAddr, 2*time.Second) | |||
There was a problem hiding this comment.
Any reason you chose a different timeout from the one below? If not, can you create a timeout const to use in both places instead.
|
Looks like you need to run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempts an initial connection to the rkt api service via the golang net api. Only try grpc if that succeeds.