Registration of the docker container factory failed after update to v0.54.1

[agebhar1]

After updating from v0.54.0 to v.54.1 the docker container factory fails.

v0.54.0

cadvisor-1  | I1207 18:29:25.894956       1 factory.go:221] Registration of the containerd container factory failed: unable to create containerd client: containerd: cannot unix dial containerd api service: dial unix /run/containerd/containerd.sock: connect: no such file or directory
cadvisor-1  | I1207 18:29:25.909764       1 factory.go:361] Registering Docker factory
cadvisor-1  | I1207 18:29:25.909796       1 factory.go:223] Registration of the docker container factory successfully

v0.54.1

cadvisor-1  | I1207 19:09:33.791068       1 factory.go:221] Registration of the containerd container factory failed: unable to create containerd client: containerd: cannot unix dial containerd api service: dial unix /run/containerd/containerd.sock: connect: no such file or directory
cadvisor-1  | I1207 19:09:33.807339       1 factory.go:221] Registration of the docker container factory failed: unable to create containerd client: containerd: cannot unix dial containerd api service: dial unix /run/containerd/containerd.sock: connect: no such file or directory

The error message for the failed docker container factory equals the containerd container factory.

[Shmarkus]

i think that you meant v0.52.0 vs v0.52.1? as the version 0.54 is not yet released https://console.cloud.google.com/artifacts/docker/cadvisor/us/gcr.io/cadvisor

I had the same error when using the latest version.

[agebhar1]

I mean 0.54.1 from GHCR (new 'home') https://github.com/google/cadvisor/pkgs/container/cadvisor/599572146?tag=0.54.1

[benji2k2]

I have the same problem, but only on my machine with an older docker version 24.0.2 (Synology DSM). On 0.54.0 it is working, on 0.54.1 i get the same error.
On two other machines with a newer Docker Version 29.1.2 everything works fine even with 0.54.1.
There are only a few commits between 0.54.0 and 0.54.1 - therefore i hope it will be relatively easy to find the "error", the only commit going into this direction is 026e791. Maybe setting the containerd-error into "global" scope leads to throwing the same error for dockerd...

[benji2k2]

I did a little bit more analysis:

In commit 7eda190 the containerdClient is also initialized for docker - but it is only needed if "storageDriver == ContainerdSnapshotterStorageDriver". But there is always an error thrown if initialization fails (the error was already thrown in 0.54.0, but only because of the change in 026e791 the error is in the variable and becomes "active" in 0.54.1.
Solution:

throw error only, if storageDriver == ContainerdSnapshotterStorageDriver - otherwise containerd is not needed for docker (in older docker versions there is no ContainerdSnapshotterStorageDriver).

[inFocus7]

Hitting this issue as well. Sorry for the naive question, but is containerd solely for storage? If so, could we safely add a graceful fallback (warn/error logs) instead of erroring, since other metrics are still fetched?

I'm on Docker MacOS, and hitting this issue as well. Locally, I built an image similar to benji's changes + an additional ignore in handler.go, and was able to run cAdvisor smoothly afterward. (changes). I tried 0.54.0, and while Docker succeeded in registration, I hit a nasty panic :rip:

[laugmanuel]

Seeing exactly the same issue on multiple hosts running docker rootless.

0.54.0 works on some hosts (on others it fails due to #3758 ), 0.54.1 cant register and does not see any containers.

[lluisd]

I suffer the same problem from my synology ds920+ on DSM 7.3.2-86009 which runs docker engine 24.0.2

on 0.54.1 and 0.55.1 I get this message:

Registration of the docker container factory failed: unable to create containerd client: containerd: cannot unix dial containerd api service: dial unix /run/containerd/containerd.sock: connect: no such file or directory

on previon 0.54.0 is still working:

Registration of the docker container factory successfully

[andrewlow]

I'm running NixOS

$ nixos-version 
25.11.3064.64049ca74d63 (Xantusia)

with docker

$ docker --version
Docker version 28.5.2, build v28.5.2

and have found that 0.54.0 works, but 0.54.1 does not in the same way as reported in this issue. Further details in the closed as duplicate issue

[benji2k2]

The PR #3796 should fix this issue. It is already merged and should be included in the next release.