Skip to content

Commit

Permalink
build: bump golang to 1.20
Browse files Browse the repository at this point in the history
Signed-off-by: David Porter <david@porter.me>
  • Loading branch information
bobbypage committed Feb 28, 2023
1 parent 42eef7f commit e6f8575
Show file tree
Hide file tree
Showing 6 changed files with 7 additions and 7 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ jobs:
test:
strategy:
matrix:
go-versions: [1.19, 1.18]
go-versions: ['1.20', '1.19']
platform: [ubuntu-20.04]
environment-variables: [build/config/plain.sh, build/config/libpfm4.sh, build/config/libipmctl.sh]
runs-on: ${{ matrix.platform }}
Expand All @@ -30,7 +30,7 @@ jobs:
test-integration:
strategy:
matrix:
go-versions: [1.19, 1.18]
go-versions: ['1.20', '1.19']
platform: [ubuntu-20.04]
environment-variables: [build/config/plain.sh, build/config/libpfm4.sh, build/config/libipmctl.sh]
runs-on: ${{ matrix.platform }}
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ docker-%:
@docker build -t cadvisor:$(shell git rev-parse --short HEAD) -f deploy/Dockerfile .

docker-build:
@docker run --rm -w /go/src/github.com/google/cadvisor -v ${PWD}:/go/src/github.com/google/cadvisor golang:1.19 make build
@docker run --rm -w /go/src/github.com/google/cadvisor -v ${PWD}:/go/src/github.com/google/cadvisor golang:1.20 make build

presubmit: lint
@echo ">> checking go mod tidy"
Expand Down
2 changes: 1 addition & 1 deletion build/integration-in-docker.sh
Original file line number Diff line number Diff line change
Expand Up @@ -72,5 +72,5 @@ GO_FLAGS=${GO_FLAGS:-"-tags=netgo -race"}
PACKAGES=${PACKAGES:-"sudo"}
BUILD_PACKAGES=${BUILD_PACKAGES:-}
CADVISOR_ARGS=${CADVISOR_ARGS:-}
GOLANG_VERSION=${GOLANG_VERSION:-"1.19"}
GOLANG_VERSION=${GOLANG_VERSION:-"1.20"}
run_tests "$GO_FLAGS" "$PACKAGES" "$BUILD_PACKAGES" "$CADVISOR_ARGS"
2 changes: 1 addition & 1 deletion build/unit-in-container.sh
Original file line number Diff line number Diff line change
Expand Up @@ -40,5 +40,5 @@ function run_tests() {

GO_FLAGS=${GO_FLAGS:-"-tags=netgo -race"}
BUILD_PACKAGES=${BUILD_PACKAGES:-}
GOLANG_VERSION=${GOLANG_VERSION:-"1.19"}
GOLANG_VERSION=${GOLANG_VERSION:-"1.20"}
run_tests
2 changes: 1 addition & 1 deletion deploy/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM mirror.gcr.io/library/golang:1.19-alpine3.16 AS build
FROM registry.hub.docker.com/library/golang:1.20-alpine3.16 AS build

# Install build depdencies for all supported arches
RUN apk --no-cache add bash build-base cmake device-mapper findutils git \
Expand Down
2 changes: 1 addition & 1 deletion deploy/canary/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
FROM golang:1.19
FROM golang:1.20
MAINTAINER dashpole@google.com

RUN apt-get update && apt-get install -y git dmsetup && apt-get clean
Expand Down

0 comments on commit e6f8575

Please sign in to comment.