Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disable buidling/deployment of python wheels #583

Merged
merged 13 commits into from
Aug 23, 2017
Merged

disable buidling/deployment of python wheels #583

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
75aa483
[appveyor] remove 'deploy' stage; only test python 2.7 and 3.6
anthrotype Aug 8, 2017
f54b514
remove terrify submodule as not needed any more
anthrotype Aug 8, 2017
2475c01
[travis] just test py2.7 and 3.6 on linux; remove extra osx python bu…
anthrotype Aug 8, 2017
86d4b19
[setup.py] only rebuild if dependency are newer; fix typo in list of …
anthrotype Aug 8, 2017
384f8b6
[ci] only run 'python setup.py test'
anthrotype Aug 8, 2017
44b5e66
[Makefile] run 'build_ext --inplace' instead of 'develop' as default …
anthrotype Aug 8, 2017
4e370f5
[Makefile] add 'develop' target; remove unnecessary 'tests' target
anthrotype Aug 8, 2017
0a3c14c
[Makefile] `setup.py test` requires setuptools; run `python -m unittest`
anthrotype Aug 8, 2017
47b4aab
[python/README.md] add ref to 'develop' target; remove 'tests', just …
anthrotype Aug 8, 2017
44f6d75
[setup.py] import modules as per nicksay's comment
anthrotype Aug 8, 2017
ab16a1b
[Makefile] add 'develop' to .PHONY targets
anthrotype Aug 8, 2017
70bb27b
[appveyor] remove unused setup scripts
anthrotype Aug 8, 2017
4add62c
[appveyor] remove unneeded setup code
anthrotype Aug 8, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
[python/README.md] add ref to 'develop' target; remove 'tests', just … 
…'make test'
  • Loading branch information
@anthrotype
anthrotype committed Aug 8, 2017
commit 47b4aabac800a0736d55609551aa50adf866ccf7
15 changes: 8 additions & 7 deletions python/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,19 +17,20 @@ following command from this directory:

### Development

For development, reinstalling the module with every change is time
consuming. Instead, we recommend using the `setuptools`
"[development mode][]" to make the module available while still being
able to edit the source files.

For convenience, you may run the following commands from this directory:
You may run the following commands from this directory:

$ make # Build the module in-place
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe leave something about "development mode" here since it's described in the paragraph right before this?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh I see now, sorry.. I can actually add an additional make develop, wdyt?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, that sounds good to me, though perhaps we should remove the references to "development mode" in the README if the in-place build is the default.


$ make tests # Test the module
$ make test # Test the module

$ make clean # Remove all temporary files and build output

If you wish to make the module available while still being
able to edit the source files, you can use the `setuptools`
"[development mode][]":

$ make develop # Install the module in "development mode"

### Code Style

Brotli's code follows the [Google Python Style Guide][]. To
Expand Down