libbrotli

[bagder]

Hey,

I created the sub project libbrotli (https://github.com/bagder/libbrotli) a while ago to help build and install a library for brotli encoding/decoding, using only code from this repository. libbrotli is only a meta-project with mostly autotools to build, install and package a "library" for brotli since this original brotli home does not provide that. It only uses compression/decompression source code from the brotli tree.

This concept seems to resonate with a decent amount of users who appreciate being able to get a library (or two actually) out of a build and install process for use in various projects.

I would prefer if this functionality was provided by the brotli project itself and I'll offer to merge/translate it over to a pull-request or something if you'll agree this is interesting. I'd prefer to remove myself as a middle man here.

[Lukasa]

I'd like to add my voice to support this idea. As the author of the Python wrapper library brotlipy, I have had to adopt the changes made by @bagder in order to extract the portions of the code that are relevant to Python library usage. This is problematic, because it forces me to make transformations on the code that make it incompatible with any brotli library installed from elsewhere, ensuring that I have to keep track of changes made in this repository rather than dynamically link against a binary library provided by the OS itself.

[anthonyryan1]

I'd also like to express support for this idea.

The brotli nginx module currently depends on @badger's libbrotli because it can't use this.

If we want to see Brotli adoption pick up on the web, we need to get the web server plugins packaged on various Linux distros. I'm personally very eager to get nginx + Brotli ready on Gentoo, but I'd strongly prefer to have the library and the encoder tools in the same git tree and on the same release cycle.

[fred-wang]

I'd also like to express support for a separate library. I've worked on WOFF2 support in Gecko and the WebKit GTK port and it would be more convenient to link to a system library instead of having duplicating code in the repos that we have to build & keep in sync.

[jyrkialakuijala]

Please go ahead with transforming libbrotli to a pull request that merges libbrotli into brotli.

[fred-wang]

With the new CMake build system it's now easy to create such brotli libraries. FYI I've opened #421.

[fholzer]

@fred-wang but that doesn't mean that @bagder's repo is no longer required, right? Built brotli with -DBUILD_SHARED_LIBS=1 but nginx's ./configure couldn't find the lib. Am i doing something wrong?

Maintaining a docker image for nginx with brotli and was hoping i could finally build using only official google repos...

[rockdaboot]

@fholzer You installed/copied/linked the libs (*.so on Linux) into a well known libs directory (e.g. /usr/local/libs/) and executed ldconf thereafter !?

[rockdaboot]

BTW, the above mentioned brotli nginx module looks for libbrotlienc while cmake here creates libbrotli_enc.

[fholzer]

@rockdaboot hi, yes, though i found the issue, which is that the header files won't be copied to $PREFIX/include when running make install. Is this expected behavior?

As a workaround you can either copy the files to a well known include directory, or use --with-cc-opt="-I /path/to/brotli/source/include" as a configure option for nginx.