Skip to content
This repository was archived by the owner on Apr 13, 2021. It is now read-only.

Comments

Fix dataflow gap#98

Merged
0xFFFFFFFE merged 1 commit intogoogle:masterfrom
ispras:dataflowjoin
Jul 13, 2016
Merged

Fix dataflow gap#98
0xFFFFFFFE merged 1 commit intogoogle:masterfrom
ispras:dataflowjoin

Conversation

@EKarpulevich
Copy link
Contributor

Self-dependencies of instructions already described and linked in "createInitialMap" function.
In function "findDefinition" we shouldn't link self-dependencies.
For examle next two instructions won't be linked:
0000000804842302 add t0, t1, qword t2
0000000804842303 and qword t2, qword ffffffffh, t2
because "and" will find "and" as definition

I used the following function for testing:

int bad(char * user)
{
        printf(user);
}

@0xFFFFFFFE 0xFFFFFFFE merged commit 356eaa8 into google:master Jul 13, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants