Skip to content

Fix minimum benchmark time with multiple threads #2118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hahnjo wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −6
Open

Fix minimum benchmark time with multiple threads #2118

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions src/benchmark_runner.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,12 +123,7 @@ BenchmarkReporter::Run CreateRunReport(
: 0;
}

// The CPU time is the total time taken by all thread. If we used that as
// the denominator, we'd be calculating the rate per thread here. This is
// why we have to divide the total cpu_time by the number of threads for
// global counters to get a global rate.
const double thread_seconds = seconds / b.threads();
internal::Finish(&report.counters, results.iterations, thread_seconds,
internal::Finish(&report.counters, results.iterations, seconds,
b.threads());
}
return report;
Expand Down Expand Up @@ -361,6 +356,9 @@ BenchmarkRunner::IterationResults BenchmarkRunner::DoNIterations() {
} else if (b.use_real_time()) {
i.seconds = i.results.real_time_used;
}
// The time is the sum over all threads, we want each of them to run the
// specificed minimum time.
i.seconds /= b.threads();

return i;
}
Expand Down
Loading