Include the benchmark's family-name in State #1511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For compat with internal library, where State::name() returns the benchmark's family name.
Member
|
can you add tests please? |
Contributor
|
Would you consider adding this to the Python API as well? That would require one fewer parses of the benchmark name into family and arguments :) |
Member
|
perfcounter failures are unrelated (seems like an apt server is down) |
dmah42
approved these changes
Jan 10, 2023
Member
|
merging this as is, but i agree Python bindings would be nice to have. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For compat with internal library, where State::name() returns the benchmark's family name.