Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update LICENSE file to clearly state which file needs BSD 3 #1366

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

oontvoo
Copy link
Member

@oontvoo oontvoo commented Mar 10, 2022

Follow up to PR/1363

@LebedevRI @dominichamon

Copy link
Collaborator

@LebedevRI LebedevRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, this is precisely what i was asking for :)

@dmah42 dmah42 merged commit 4a1943d into google:main Mar 14, 2022
@jwnimmer-tri
Copy link

Regarding #1321 up through this PR.

The bzl file in question here came from Drake, a project that I help maintain on behalf of Toyota Research.

If you like, I have authority to CLA the bzl contents over to the standard googlebenchmark license so that you don't need to carry around this license addendum forevermore. Let me know if you'd like me to help with that?

For a mechanism, I suppose I could open a PR that removes the BSD-3-Clause contents from LICENSE as well as the bzl file itself, and my signing of that CLA on that PR would would suffice?

@dmah42
Copy link
Member

dmah42 commented Jul 15, 2022

i appreciate the offer, but it would need to be changed in the original source for us to inherit the new license. this doesn't cause any licensing issues as far as i'm aware as BSD-3 and Apache-2 are compatible, so i don't believe any further action is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants