Skip to content

Conversation

@dmah42
Copy link
Member

@dmah42 dmah42 commented Jun 3, 2021

No description provided.

@google-cla google-cla bot added the cla: yes label Jun 3, 2021
@dmah42
Copy link
Member Author

dmah42 commented Jun 3, 2021

failing due to existing sanitizer badness (yay?). making a new PR to try to solve that first.

@google-cla
Copy link

google-cla bot commented Jun 3, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added cla: no and removed cla: yes labels Jun 3, 2021
@dmah42 dmah42 force-pushed the sanitizer_builds branch from 49d9250 to 493ae94 Compare June 3, 2021 15:19
@google-cla google-cla bot added cla: yes and removed cla: no labels Jun 3, 2021
@dmah42 dmah42 marked this pull request as ready for review June 3, 2021 16:04
@dmah42 dmah42 requested a review from LebedevRI June 3, 2021 16:04
@LebedevRI
Copy link
Collaborator

This seems fine to me.
MSan is complicated, you need to build every lib you link to with msan.

@dmah42 dmah42 merged commit bdd6c44 into main Jun 3, 2021
@dmah42 dmah42 deleted the sanitizer_builds branch June 3, 2021 18:45
vincenzopalazzo pushed a commit to vincenzopalazzo/benchmark that referenced this pull request Feb 8, 2022
* Enable various sanitizer builds in github actions

* try with off the shelf versions

* nope

* specific version?

* rats

* oops

* remove msan for now

* reorder so env is set before building libc++
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants