Skip to content

Unit-tests fail to build due to signed/unsigned integer comparisons #741

@Sigill

Description

@Sigill

Debian 9.5 Stretch / GCC 6.3.0 / Googletest 1.8.1

The string_utils unit-tests fail to build with the following error:

/home/cfx/Dev/google-benchmark/benchmark.git/test/string_util_gtest.cc:12:5:   required from here
/home/cfx/Applications/googletest-1.8.1/include/gtest/gtest.h:1444:11: error: comparison between signed and unsigned integer expressions [-Werror=sign-compare]
   if (lhs == rhs) {
       ~~~~^~~~~~

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions