Build fails with MSVC 2017

[andan342]

We are trying to use Google Benchmark with our Visual Studio 2017 project. When compiling, the following errors:

... \test\output_test_helper.cc(206): error C2039: 'streampos': is not a member of 'std::basic_ios<char,std::char_traits<char>>'

also

... \test\output_test_helper.cc(210): error C2784: 'bool std::operator >(const std::pair<_Ty1,_Ty2> &,const std::pair<_Ty1,_Ty2> &)': could not deduce template argument for 'const std::pair<_Ty1,_Ty2> &' from 'std::fpos<_Mbstatet>'

Also the warnings:

... \include\benchmark/benchmark.h(645): warning C4141: 'inline': used more than once

Same for line 648, as the macro BENCHMARK_ALWAYS_INLINE expands to __forceinline.

Checked with STL versions 14.11.25503, 14.10.25008, as shipped with MS Visual Studio. It compiles fine with gcc on Linux though.

[dmah42]

The latter (inline) warning we're aware of and there was some PR to fix it at some point. The others are new. We have an appveyor build for MSVC that seems to be green (mostly): https://ci.appveyor.com/project/google/benchmark. This includes a Vis Studio 2017 configuration, so i'm curious what's different about your setup. Dominic Hamon | Google *There are no bad ideas; only good ideas that go horribly wrong.*

…

On Sat, Mar 10, 2018 at 6:47 AM, Andrej Andrejev ***@***.***> wrote: We are trying to use Google Benchmark with our Visual Studio 2017 project. When compiling, the following errors: ... \test\output_test_helper.cc(206): error C2039: 'streampos': is not a member of 'std::basic_ios<char,std::char_traits<char>>' also ... \test\output_test_helper.cc(210): error C2784: 'bool std::operator >(const std::pair<_Ty1,_Ty2> &,const std::pair<_Ty1,_Ty2> &)': could not deduce template argument for 'const std::pair<_Ty1,_Ty2> &' from 'std::fpos<_Mbstatet>' Also the warnings: ... \include\benchmark/benchmark.h(645): warning C4141: 'inline': used more than once Same for line 648, as the macro BENCHMARK_ALWAYS_INLINE expands to __forceinline. Checked with STL versions 14.11.25503, 14.10.25008, as shipped with MS Visual Studio. It compiles fine with gcc on Linux though. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#551>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAfIMi4p5pziEKldJOR5DKiP5s4oJ9yYks5tc3cBgaJpZM4SlKxs> .

[andan342]

Some progress here. We are compiling whole solution with the flag /std:c++latest on MSVC, and get an error, as in the OP.

Problem reproduced online. If you remove the /std:c++latest, it compiles fine.

So is it a deprecated STL feature used in Google Benchmark?

Otherwise, I guess we'll need to isolate Google Benchmark-dependent projects, so they don't inherit /std:c++latest option from solutions CMake script - I wonder if that's possible...

[qis]

Can confirm the warnings. Is it a good idea to remove the additional inline from BENCHMARK_ALWAYS_INLINE inline functions and declare #define BENCHMARK_ALWAYS_INLINE inline for __clang__?

[pleroy]

Do you see the inlining warnings at the latest commit? If so what compiler are you using and what /std flag? For some reason this issue keeps popping up over and over again but AFAICT it was fixed a while ago.

[EricWF]

I spoke to the MSVC team about this they couldn't reproduce the warning with MSVC Microsoft (R) C/C++ Optimizing Compiler Version 19.13.26020. I suspect they realized the warning was bogus, and removed it.

I'm not sure we should do anything about this.

[pleroy]

Actually, the warning reproduces fine, it just depends in the order of the two directives, see https://godbolt.org/g/jWEmpV. (Godbolt has an old compiler but I am running 15.7 preview 3 which was released this week, and I see the same thing.) This was fixed in #469 a long time ago but somehow people keep reporting it.

[EricWF]

@pleroy Thanks for the correction. I'll pass it on to the MSVC team.

[dmah42]

should we close this issue?

[qis]

@dominichamon I had no problems so far using Google Benchmark with vcpkg. All warnings are gone.

[LebedevRI]

@dominichamon I think this can be closed now?

[traceon]

Submitted a PR #721 for this (which still exists when compiling in C++17 mode, at least for clang that comes with XCode 10.1):

... \test\output_test_helper.cc(206): error C2039: 'streampos': is not a member of 'std::basic_ios<char,std::char_traits<char>>'