* Report unrecognized arguments from BENCHMARK_MAIN() macro (google#332) * BENCHMARK_MAIN() now reports unrecognised command-line flags (see google#320) * add benchmark::ReportUnrecognizedArguments() Update BENCHMARK_MAIN() to use ReportUnrecognizedArguments() instead of having the reporting code directly in the macro. See issue google#320 for reference * let's stick to american english -- fix type in ReportUnrecognizedArguments() * make ReportUnrecognizedArguments() print to stderr * make ReportUnrecognizedArguments() return true if any arguments have been reported (i.e. argc > 1) * Disable iOS CPU Frequency readout (google#335) * Add macro definition for iOS Add an additional macro definition for iOS. iOS is defined as a Mac OSX invariant in the TargetConditionals include, thus we treat it as a subset of OSX within the defines. * Skip error for hw.cpufrequency on iOS hw.cpufrequency is not available on iOS devices. As there is no way to reliably retrieve the CPU frequency on iOS we are printing out a warning that we were unable to detect the CPU frequency and set it to 0. This only disables cpu frequency readouts on actual physical iOS devices. Running this code on the simulator still gives the cpu architecture of the host computer as the simulator passes down the sysctl calls to OSX. * Fix typename for powerpc (google#337) * Support for Web platforms (google#340) * Implement cycleclock::Now for PNaCl * Make cycleclock::Now compatible with NaCl/ARM * Support Emscripten (Asm.js, WebAssembly) * Rearrange #ifs from to handle specific cases first * DoNotOptimize without inline asm for Emscripten & PNaCl * Add user-defined counters. (google#262) * Added user counters, and move use of bytes_processed and items_processed to user counter logic. Each counter is a string-value pair. The counters were made available through the State class. Two helper virtual methods were added to the Fixture class to allow convenient initialization and termination of the counters: InitState() and TerminateState(). The reporting of the counters is buggy and is still a work in progress, to be completed in the next commits. * fix bad removal of BenchmarkCounters code during the merge * add myself to AUTHORS/CONTRIBUTORS * fix printing to std::cout in csv_reporter * bytes_per_second and items_per_second are now in the UserCounters class * add user counters to json reporter * moving bytes_per_second and items_per_second to their old state * console reporter dealing ok with user counters. * update unit tests for user counters * CSVReporter now prints user counters too. * cleanup user counters * reverted changes to cmake files which should have gone into later commits * fixture_test: fix gcc 4.6 compilation * remove ctor with default argument see google#262 (comment) * use (auto-defined) BENCHMARK_HAS_CXX11 instead of BENCHMARK_INITLIST. google#262 (comment) * leanify counters API Discussions: API complexity: google#262 (comment) remove std::string dependency (WIP): google#262 (comment) spacing & alignment: google#262 (comment) * remove std::string dependency on public API - changed counter name storage to char* * Counter ctor: use overloads instead of default arguments discussion: google#262 (comment) * Use raw pointers to remove dependency on std::vector from public API . For more info, see discussion at google#262 (comment) . * Move counter implementation from benchmark.cc to counter.cc. See discussion: google#262 (comment) . * Remove unused (commented-out) code. * Moved thread counters to ThreadStats. * Counters: fixed copy and move constructors. * Counter: use an inplace buffer for small names. * benchmark_test: move counters test out of CXX11 preprocessor conditional. * Counter: fix VS2013 compilation error in char[] initialization. * Fix typo. * Expose counters from State. See discussion: google#262 (comment) * Changed counters interface to map-like. * Fix printing of user counters in ConsoleReporter. * Applied clang-format to counter.cc and console_reporter.cc. Command was `clang-format -style=Google -i counter.cc console_reporter.cc` I also applied to all other files, but the changes were very far-reaching so I rolled those back. * Rename Counter::Flags_e to Counter::Flags * Fix use of reserved names in Counter and BenchmarkCounters. * Counter: Fix move ctor bug + change order of members. * Fixture: remove tentative methods InitState() and TerminateState(). * Update fixture_test to the new Fixture interface. * BenchmarkCounters: fixed a bug in the move ctor. Remove call to CHECK_LT(). CHECK_LT() was making the size_t lookup take ~double the time of a string lookup! * BenchmarkCounters: add option to not print zero counters (defaults to false). * Add test to compare counter storage and access with std::map. * README: clarify cost of counter access modes. * move counter access test to an own test. * BenchmarkCounters: add move Insert() * Counters access test: add accelerated lookup by name. * Fix old range syntax. * Fix missing include of cstdio * Fix Visual Studio warning * VS2013 and lower: fix use of snprintf() * VS2013: fix use of char[] as a member of std::pair<>. * change counter storage to std::map * Remove skipZeroCounters logic * Fix VS compilation error. * Implemented request changes to PR google#262. * PR google#262: More requested changes. * README: cleanup counter text. * PR google#262: remove clang-format changes for preexisting code * Complexity+Counters: fix counter flags which were being ignored. * Document all Counter::Flag members * fixed loss of counter values * ConsoleReporter: remove tabular printing of user counters. * ConsoleReporter: header printing should not be contingent on user counter names. * Minor white space and alignment fixes. * cxx03_test + counters: reuse the BM_empty() function. * user counters: add note to README on how counters are gathered across threads * Rename BenchmarkCounters to UserCounters (google#346) The name UserCounters seems more accurate than the pleonastic BenchmarkCounters. * Add command line option --benchmark_counters_tabular * Tabular counters: fix dangling reference to color_output_. * Fix use of C-style cast. * Tabular counters: fix missing cast on MSVC. * Fix std::string detection hack for SetLabel. Previously benchmark_api.h wasn't allowed to include standard library headers. For this reason SetLabel had a hack to accept std::string without including <string>. The hack worked by attempting to detect the injected class name `basic_string`. However Clang has changed it's behavior regarding injected class names so this hack no longer works. This patch removes the hack and replaces it with a function that actually names std::string. However we still cannot pass std::string across the dylib boundary because of libstdc++'s dual C++11 ABI. * Implement ClobberMemory() and fix DoNotOptimize on MSVC. (google#352) I recently learned Windows provides a function called _ReadWriteBarrier which is literally ClobberMemory under a different name. This patch uses it to implement ClobberMemory under MSVC. * Include cstdlib for timespec. Clang modules demands that. (google#353) * Fix ICC compiler warnings (google#358) fixes google#354 The build fails with ICC17 because of warnings and Werror. What is the correct solution to fix it? Should a patch disable Werror for ICC (or maybe all non known compilers) disable the false postive warnings for all files. This could be done using: add_cxx_compiler_flag(-wd2102) #ICC17u2: Many false positives for Wstrict-aliasing add_cxx_compiler_flag(-wd2259) #ICC17u2: non-pointer conversion from "long" to "int" may lose significant bits (even for explicit static cast, sleep.cc(44)) add_cxx_compiler_flag(-wd654) #ICC17u2: overloaded virtual function "benchmark::Fixture::SetUp" is only partially overridden (because of deprecated overload) disable warnings at file level or some other granularity * Replace int64_t usages with 'int' instead. (google#359) Previously the constants used for converting between different units of time were declared using int64_t. However we should only use explicitly sized integer types when they are required, and should use 'int' everwhere else, and there is no good reason to use int64_t here. For that reason this patch changes the type of the constants. This should help address issue google#354 as well. * Fix CPU frequency parsing on Linux (google#355) (google#356) * Fix reading CPU info from file Macro CHECK do nothing for release mode, meaning it doesn't invoke the arguments * Add myself to AUTHORS and CONTRIBUTORS * Add BENCHMARK_BUILD_32_BITS option and add builders to test it (google#360) * Add BENCHMARK_BUILD_32_BITS option and add builders to test it * Attempt to fix travis configuration * Make add_required_cxx_compiler_flag cause an error when the flag isn't supported * add gcc-multilib dependancy on travis * attempt to fix travis.yml parsing error * Require g++-multilib instead of gcc-multilib * Add 32 bit release configurations * Attempt to fix libc++ travis build w/ 32 bits * Work around CMake configuration failure on Travis * Python 2/3 compatibility (google#361) * [tools] python 2/3 support * update authors/contributors * Fixes google#357: broken RMS values when time unit is set. * User counters: document tabular output in README.md * Add CMake Package Config files during install - Remove target_include_directories of ${PROJECT_SOURCE_DIR}/include to fix error: Target "benchmark" INTERFACE_INCLUDE_DIRECTORIES property contains path which is prefixed in the source directory. * Fix ${include_install_dir} * Remove unnecessary benchmark subfolder * Fixes google#357: broken RMS values when time unit is set. (google#362) * Fix cmake file not to use CMAKE_SOURCE_DIR (google#367) Using CMAKE_SOURCE_DIR benchmark cannot be built as part of a project. This change allows to add benchmark using add_subdirectory to a bigger project. * Enable <cassert> by removing -DNDEBUG when running the tests. In non-debug builds CMake automatically adds -DNDEBUG, this means that uses of `assert` in the tests are disabled for non-debug builds. Obviously we want these tests to run, regardless of configuration. This patch strips -DNDEBUG during non-debug builds and adds -UNDEBUG just to be sure. * Add Benchmark::Iterations for explicit iteration count control - Fixes google#370 (google#373) * Add Benchmark::Iterations for explicitly specifying the number of iterations to use. * Document that benchmark::Iterations should not be used to limit benchmark runtimes * Don't limit benchmarks with manual timers to 5x the elapsed real time. When using CPU time to determine the correct number of iterations the library additionally checks if the benchmark has consumed 5x the minimum required time according to the wall clock. This prevents benchmarks with low CPU usage from running for much longer than actually intended. However when a benchmark uses a manual timer this heuristic isn't helpful and likely isn't correct since we don't know what the manual timer actually measures. This patch removes the above restriction when a benchmark specifies a manual timer. * fix android compilation (google#372) * fix android compilation * checking __GLIBCXX__ and __GLIBCPP__ macro in addition to __ANDROID__ * using vsnprintf instead of std::vsnprintf to compile on Android * removed __GLIBCPP__ check on Android * StringPrintF instead of std::to_string for Android * fix for android NDK r10e (google#375) * Support VS2017 on AppVeyor (google#376) * Fixes google#378 (hopefully). Unit tests for counters to follow. The problem was that the call to Finish() the user counters was lost in a big merge. If I had already written the tests for the user counters, this would probably have been catched earlier. * Fixes google#378 coercion to double was causing counter to forget its flags, changed it so that its value is updated directly * User counters: fix misplaced newline in console reporter header. * Reporter tests: reuse csv header. * User counter tests: first version. * User counters: add more unit tests. ... The tests are still missing a way to check actual validity of numerical results; this will be done next. As they currently are, the tests pass, but the problem detected with google#378 is still standing and the results with non-standard counters are wrong. * Unit testing: add facilities to check benchmark results. This is needed for examining the values of user counters (needed for google#348). It is also needed for checking the values of standard benchmark results like items_processed or complexities (for example, checking the standard deviation is needed for unit testing google#357 as discussed in google#362). * Remove some whitespace. * Add epsilon check macros for float comparison. * Use const char* instead of std::string in entry name lookup. * ResultsCheckerEntry: add more getter functions. * Results check: add checks with epsilon. * User counters: add more tests. * Avoid compiler-specific pragmas in result check macros. - Epsilon is now understood as relative to expected value. - Improve error messages for epsilon checks. * Add log of the benchmark name when checking results. * Make result checkers execute on all regex-matching benchmarks. * Fix ResultsCheckerEntry::NumThreads() * Add (currently failing) tests for user counters with threads. * Console reporting of user counters: print rates like non-rates. * Fix expected values of user counters as rates in unit tests. * Result checking: move some function definitions to source file. * Adopt standard style. * Rename ResultsCheckerEntry to Results. * Remove unused prototype. * Add missing include for providing std::function. * Add missing include of stringstream. * CHECK_EPS: Use parentheses to wrap macro arguments. * Remove whitespace. * Simplify printing of counters in console reporter. * Fix g++-4.8 compile errors. * Fix VS2013 quirk. * CHECK(): rename EPS to FLOAT for consistency with googletest style. * Fix VS warning. * Fix brace formatting (Habits die hard!). * CHECK_BENCHMARK_RESULTS() was too inconspicuous. * Make Results::GetTime() receive an enum. * Improve some comments. * Add output_test.h to output_test_helper for VisualStudio editing. * Fix indentation. [ci-skip] * Ensure all the necessary keys are present before parsing JSON data (google#380) This prevents errors when additional non-timing data are present in the JSON that is loaded, for example when complexity data has been computed (see google#379). * Fix: --benchmark_counters_tabular was not being passed to tests. * Add first unit test for benchmark_tabular_counters. * Add test for tabular output of rate counters. * Console reporter: add /s prefix to counter rates. * Allow different counter sets in CSV reporting. * Add unit test for counter sets. * Extend tabular counter tests to different counter sets. * Fix (that is, ignore) clang compile error. * Fix dropped-style elses. * Fix pragma clang ignore with gcc. * Trying again to fix error caused by -Wunused-function. This thing with the pragma ignore was getting out of hand: now MinGW (and probably GCC) was erroring too. So I chose to move the definition of IsZero() out of the anonymous namespace into benchmark.cc. * test commit * Add macOS builds to .travis.yml (google#389) * Remove unnecessary whitespace in travis yaml * Associate the required include directory with the benchmark library (google#393) Using target_include_directories CMake will implicitly add the the necessary include paths to targets which link against the benchmark library. This is useful when the benchmark repo is included as a subdirectory in another CMake build. * Fix google#342: DoNotOptimize causes compile errors on older GCC versions. (google#398) * Fix google#342: DoNotOptimize causes compile errors on older GCC versions. DoNotOptimize uses inline assembly contraints to tell the compiler what the type of the input variable. The 'g' operand allows the input to be any register, memory, or immediate integer operand. However this constraint seems to be too weak on older GCC versions, and certain inputs will cause compile errors. This patch changes the constraint to 'X', which is documented as "any operand whatsoever is allowed". This appears to fix the issues with older GCC versions. However Clang doesn't seem to like "X", and will attempt to put the input into a register even when it can't/shouldn't; causing a compile error. However using "g" seems to work like "X" with GCC, so for this reason Clang still uses "g". * Try alternative formulation to placate GCC * Use the sample version of standard deviation (google#383) * remove unnecessary weights * use sample standard deviation * add contributor information * remove redundant code * initialize variable to eliminate compiler warning * Use NEW settings for CMP0063 policy (google#399) This removes warnings when using CMake >= 3.3 if you have symbol visibility set. * Revert "Use NEW settings for CMP0063 policy (google#399)" (google#401) This reverts commit af54206. * Add ClearRegisteredBenchmark() function. (google#402) * Add ClearRegisteredBenchmark() function. Since benchmarks can be registered at runtime using the RegisterBenchmark(...) functions, it makes sense to have a ClearRegisteredBenchmarks() function too, that can be used at runtime to clear the currently registered benchmark and re-register an entirely new set. This allows users to run a set of registered benchmarks, get the output using a custom reporter, and then clear and re-register new benchmarks based on the previous results. This fixes issue google#400, at least partially. * Remove unused change * Fix google#403 HAVE_${VAR} not passed to makefile (google#404) Add definition of ${VAR} to makefiles if specified as part of cmake parameter. * Make Benchmark a single header library (but not header-only) (google#407) * Make Benchmark a single header library (but not header-only) This patch refactors benchmark into a single header, to allow for slightly easier usage. The initial reason for the header split was to keep C++ library components from being included by benchmark_api.h, making that part of the library STL agnostic. However this has since changed and there seems to be little reason to separate the reporters from the rest of the library. * Fix internal_macros.h * Remove more references to macros.h * Fix ThreadCPUUsage when running on RTEMS. (google#414) Change ThreadCPUUsage to call ProcessCPUUsage if __rtems__ is defined. RTEMS real time OS doesn't support CLOCK_THREAD_CPUTIME_ID. See https://github.com/RTEMS/rtems/blob/master/cpukit/posix/src/clockgettime.c#L58-L59 Prior to this change, ThreadCPUUsage would fail when running on RTEMS with: ERROR: clock_gettime(CLOCK_THREAD_CPUTIME_ID, ...) failed * Google-style cleanups (google#416) * more clang tidy cleanups (google#417)

CXXFeatureCheck for regex for cross compiling failing #403

Description

Metadata

Metadata

Assignees

Labels

Type

Projects

Milestone

Relationships

Development

Issue actions