Create the file "test_util.go" #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogerlucena
force-pushed
the
test-utils-build
branch
from
f1fdc1e to
50a957d
Compare
rogerlucena
changed the title
rogerlucena
force-pushed
the
test-utils-build
branch
from
50a957d to
b62fb8a
Compare
thiagovas
approved these changes
Sep 22, 2020
rbkloss
approved these changes
Sep 22, 2020
rogerlucena
force-pushed
the
test-utils-build
branch
from
e17196e to
e90b590
Compare
jlsotomayorm
approved these changes
Sep 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some functions like
mustBuildLiteralandmustBuildPredicate, previously defined inside "expression_test.go", are useful for other test files as well.Then, this PR comes to isolate these useful functions in one unique file, "test_util.go", and refactor "expression_test.go" to import these functions from there.