Add a config to build and run on PRs. #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the CI config targets 22.04 with tests being run for the LLVM tools built with clang. We also build GCOV tools built with GCC but do not test them yet since a couple of tests are failing. Also fix the commit hash check.
shenhanc78
reviewed
Jul 18, 2024
| push: | ||
| branches: [ $default-branch ] | ||
| pull_request: | ||
| types: [opened, reopened, synchronize] |
There was a problem hiding this comment.
Does this trigger CI when user updates his PR? (Do we also want "edited"?)
There was a problem hiding this comment.
Assuming by update you mean adding more commits I think that is covered by synchronize. Edited covers the cases where title, description or base branch is edited [1]. Let me know if you still think it's worth adding the edited.
[1] https://frontside.com/blog/2020-05-26-github-actions-pull_request/
|
Thanks. LGTM. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the CI config targets 22.04 with tests being run for the LLVM tools built with clang. We also build GCOV tools built with GCC but do not test them yet since a couple of tests are failing.
Also fix the commit hash check.