-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add AWS IAM Credential Support to apt-golang-s3 #6
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed it! |
Hi folks! Looks like the agreement is approved and shows up for me. Is there anything else you need from me for reviewing this? |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
@patcable I'll take a look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
One of the things I'd like to get away from is having to use credentials at all in my s3 resources and instead rely on the host's IAM role. This patch will make that happen - using static credentials if they're there, and falling back on the default AWS Credential Provider Path if they are not.
This is, admittedly, difficult to test. The existing test should pass fine, but short of spinning up an EC2 node with host credentials I'm not sure how to write a test for it. Suggestions welcome there.
In any case, thanks for creating this tool. It solves my problem of having to install an entire python toolchain just to get some updates from s3, which makes me pretty thrilled 👍