Use android/system/core to provide libcutils, liblp, libsparse #1206
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adelva1984
approved these changes
May 29, 2025
jemoreira
approved these changes
May 29, 2025
| @@ -34,6 +35,7 @@ cc_library( | |||
| "mapped_file.cpp", | |||
| "parsebool.cpp", | |||
| "parsenetaddress.cpp", | |||
| "properties.cpp", | |||
There was a problem hiding this comment.
could we use libbase from android too? If you do that first you won't need to fix this copy.
There was a problem hiding this comment.
libbase is going to be more trouble since the internal version doesn't include the logging parts in favor of using abseil logging. Either we'll have to get creative in copybara or we'll have to migrate to abseil logging in our code here on GitHub.
Databean
added
kokoro:force-run
GoogleCuttlefishTesterBot
removed
kokoro:run
Databean
added
kokoro:force-run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug: b/421034556