Repository navigation
Conversation
The exporter stored neither, so a span that ended with an exception read back as UNSET with no events. Store status code, status description and events, restore them on read, and add the columns to existing databases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please ensure you have read the contribution guide before creating a pull request.
Link to Issue or Description of Change
1. Link to an existing issue (if applicable):
SqliteSpanExporterstored neither a span's status nor its events, so a span that ended with an exception read back asUNSETwith no events. This stores the status code, status description and events, restores them in_row_to_readable_span, and adds the three columns to a database created by an earlier version when it is opened.Testing Plan
Unit Tests:
pytest tests/unittests/telemetry: 880 passed, 7 xfailed. Four new tests intest_sqlite_span_exporter.py; the two covering status and events fail without the change.Manual End-to-End (E2E) Tests:
Ran the reproduction script from #7484.
Before:
After:
A database file written by the previous version is upgraded on open; that case has its own test.
Checklist
Additional context
The exporter is not imported elsewhere in this repository, so the end-to-end check above uses it directly through a
TracerProvider, as the issue does.