-
Notifications
You must be signed in to change notification settings - Fork 2k
Added require_confirmation_for_transfer flag #3021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @Whynot63, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the control mechanism for LLM agent transfers by introducing a new configuration flag. This flag allows for an explicit confirmation step from the user before an agent transfer is executed, providing greater oversight and preventing unintended transfers. The change involves adding the flag to the agent's definition and then wiring it into the agent transfer logic. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
Response from ADK Triaging Agent Hello @Whynot63, thank you for creating this PR! Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). You can do so at https://cla.developers.google.com/. In addition, this PR is a new feature, could you please associate a Github issue with this PR? If there is no existing issue, could you please create one? Finally, could you please include a This information will help reviewers to review your PR more efficiently. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a require_confirmation_for_transfer
flag to enable explicit user confirmation for agent transfers. The implementation is straightforward and correctly wires the new flag from the LlmAgent
configuration to the FunctionTool
that handles the transfer. My review focuses on improving code clarity and adhering to Python's style guidelines. I've suggested a more descriptive docstring for the new flag and a correction to indentation to align with PEP 8 standards.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Hi @Whynot63, thanks for the PR! Could you please take two quick actions before we proceed?
|
Added flag for explicit agent transfer