feat: add endpoint to generate memory from session

[guillaumeblaquiere]

In relation with #2416

[gemini-code-assist]

Summary of Changes

Hello @guillaumeblaquiere, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new API capability that enables the system to generate and store memory from existing user sessions. This enhancement provides a direct mechanism to persist session data, which is crucial for maintaining context and improving user experience in subsequent interactions.

Highlights

• New API Endpoint: A new POST endpoint "/apps/{app_name}/users/{user_id}/sessions/{session_id}/add_to_memory" has been introduced in src/google/adk/cli/adk_web_server.py.
• Session Memory Generation: This endpoint allows for a specific session to be retrieved and then added to the system's memory service, facilitating the generation of memory from existing sessions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[adk-bot]

Response from ADK Triaging Agent

Hello @guillaumeblaquiere, thank you for creating this PR!

Could you please include a testing plan section in your PR to talk about how you will test this new endpoint? This will save time for PR review.

This information will help reviewers to review your PR more efficiently. Thanks!

[gemini-code-assist]

Code Review

This pull request adds a new endpoint to generate memory from a session. My review identifies a critical issue where a non-existent session is not handled, which would lead to a server error. Additionally, the new endpoint function has a non-descriptive name. I've provided a code suggestion to address these points by adding proper error handling and renaming the function for clarity.

[guillaumeblaquiere]

/gemini review

[gemini-code-assist]

Code Review

This pull request introduces a new endpoint /apps/{app_name}/users/{user_id}/sessions/{session_id}/add_to_memory to add a session's events to the memory service. The implementation is straightforward, but I've suggested a few improvements to enhance code quality and adhere to best practices for API development. Specifically, I've recommended adding a proper docstring, a return type hint, removing a redundant comment, and using a more appropriate HTTP status code for the response.

[DeanChensj]

Thanks!

[DeanChensj]

Could you fix the failing tests?

[guillaumeblaquiere]

Could you fix the failing tests?

Should be OK. I also added a test for my new endpoint. I had to change the mock type for the memory service.
I let you review these changes (both recommended by Gemini Code Assist)

And sorry for the delay, I'm CET timezone based (Europe/Paris)

[DeanChensj]

Could you fix the style check using autoformat.sh?

[guillaumeblaquiere]

ou fix the style check using autoformat.

Done. Thanks for you patience

[DeanChensj]

Thanks!

[DeanChensj]

Merged in 2595824