Skip to content

Conversation

@ariefshaik7
Copy link
Contributor

@ariefshaik7 ariefshaik7 commented Nov 4, 2025

The unit test workflow is failing because it attempts to install non-existent dependency groups.

  • CONTRIBUTING.md and .github/workflows/unit-tests.yaml both instruct uv to install extras named test, eval, and a2a.

  • However, the pyproject.toml file does not define test, eval, or a2a as dependency groups.

This PR corrects the mismatch by:

  • Adding the optional dependencies in pyproject.toml using uv add --optional test pytest , uv add --optional test pytest-asyncio and correcting the workflow

Closes #12

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @ariefshaik7, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a failing unit test workflow caused by a mismatch between the dependency groups specified in the workflow configuration and those defined in the pyproject.toml file. It introduces the missing test dependency group and includes pytest as a dependency.

Highlights

  • Dependency Group: Adds the test optional dependency group to pyproject.toml, including pytest>=8.4.2.
  • Workflow Fix: Corrects the unit test workflow by ensuring that the dependencies specified in .github/workflows/unit-tests.yaml match the dependency groups defined in pyproject.toml.
Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/unit-tests.yaml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix the unit test workflow by adding the missing test optional dependency group to pyproject.toml. The change is correct in principle, as it moves towards the standard PEP 621 for defining extras. However, the new test group is missing the pytest-asyncio dependency, which is required by the unit tests. I've added a comment with a suggestion to include it.

@ariefshaik7 ariefshaik7 closed this Nov 4, 2025
@ariefshaik7 ariefshaik7 reopened this Nov 4, 2025
ariefshaik7 and others added 3 commits November 4, 2025 08:18
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
@hangfei hangfei merged commit d4a2614 into google:main Nov 4, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix: Unit-tests workflow failure on main

2 participants