-
Notifications
You must be signed in to change notification settings - Fork 279
feat: add new functionality to improve user experience #306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
SoulSniper1212
wants to merge
3
commits into
google:main
Choose a base branch
from
SoulSniper1212:fix-issue-284-functiontool-confirmation
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+418
−21
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Binary file not shown.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # Confirmation Example | ||
|
|
||
| This example demonstrates how to use the confirmation feature in FunctionTools. | ||
|
|
||
| ## Features Demonstrated | ||
|
|
||
| 1. **Static Confirmation**: Using `RequireConfirmation: true` in the tool config to always require confirmation | ||
| 2. **Dynamic Confirmation**: Using `ctx.RequestConfirmation()` within the tool function to request confirmation at runtime | ||
|
|
||
| ## Running the Example | ||
|
|
||
| ```bash | ||
| go run main.go | ||
| ``` | ||
|
|
||
| ## How It Works | ||
|
|
||
| 1. The example creates two types of tools that perform "file write" operations: | ||
| - A tool that uses static confirmation (defined in config) | ||
| - A tool that requests confirmation dynamically (in the function) | ||
|
|
||
| 2. When either tool is called by the LLM: | ||
| - The static confirmation tool will always show a note in its description that it requires confirmation | ||
| - The dynamic confirmation tool will pause execution when `RequestConfirmation` is called | ||
|
|
||
| 3. The confirmation request includes the tool name, a hint, and any associated payload data | ||
|
|
||
| This is useful for safety-critical operations like file system modifications or system commands that should require user approval before execution. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,106 @@ | ||
| // Copyright 2025 Google LLC | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| // Package main demonstrates the use of confirmation in FunctionTools. | ||
| package main | ||
|
|
||
| import ( | ||
| "context" | ||
| "fmt" | ||
| "log" | ||
| "os" | ||
|
|
||
| "google.golang.org/adk/agent" | ||
| "google.golang.org/adk/llm" | ||
| "google.golang.org/adk/model" | ||
| "google.golang.org/adk/runner/full" | ||
| "google.golang.org/adk/session" | ||
| "google.golang.org/adk/tool" | ||
| "google.golang.org/adk/tool/functiontool" | ||
| ) | ||
|
|
||
| type WriteFileArgs struct { | ||
| Filename string `json:"filename"` | ||
| Content string `json:"content"` | ||
| } | ||
|
|
||
| // writeWithConfirmation simulates a file write operation that requires confirmation | ||
| func writeWithConfirmation(ctx tool.Context, args WriteFileArgs) (string, error) { | ||
| // Request confirmation before writing the file | ||
| err := ctx.RequestConfirmation("Writing file: "+args.Filename, map[string]any{ | ||
| "filename": args.Filename, | ||
| "content": args.Content, | ||
| }) | ||
| if err != nil { | ||
| // If confirmation was required, the flow will pause and wait for confirmation | ||
| // In this example, we would normally resume after receiving confirmation | ||
| return "", err | ||
| } | ||
|
|
||
| // After confirmation is granted, we would write the file | ||
| // For this example, we'll just simulate it | ||
| return fmt.Sprintf("File %s written successfully", args.Filename), nil | ||
| } | ||
|
|
||
| // staticConfirmationTool is a file operation that always requires confirmation | ||
| func staticConfirmationTool(ctx tool.Context, args WriteFileArgs) (string, error) { | ||
| return fmt.Sprintf("Static confirmation tool executed for file: %s", args.Filename), nil | ||
| } | ||
|
|
||
| func main() { | ||
| ctx := context.Background() | ||
|
|
||
| // Create a function tool that requests confirmation dynamically | ||
| dynamicTool, err := functiontool.New(functiontool.Config{ | ||
| Name: "write_file_dynamic", | ||
| Description: "Write content to a file, with dynamic confirmation", | ||
| }, writeWithConfirmation) | ||
| if err != nil { | ||
| log.Fatalf("Failed to create dynamic confirmation tool: %v", err) | ||
| } | ||
|
|
||
| // Create a function tool that always requires confirmation via config | ||
| staticTool, err := functiontool.New(functiontool.Config{ | ||
| Name: "write_file_static", | ||
| Description: "Write content to a file, with static confirmation requirement", | ||
| RequireConfirmation: true, | ||
| }, staticConfirmationTool) | ||
| if err != nil { | ||
| log.Fatalf("Failed to create static confirmation tool: %v", err) | ||
| } | ||
|
|
||
| // Create a simple LLM agent with the tools | ||
| llmAgent, err := agent.NewLLMAgent(ctx, agent.LLMAgentConfig{ | ||
| Name: "file_operator", | ||
| Model: &model.MockModel{}, // Use mock model for example | ||
| Tools: []tool.Tool{dynamicTool, staticTool}, | ||
| }) | ||
| if err != nil { | ||
| log.Fatalf("Failed to create agent: %v", err) | ||
| } | ||
|
|
||
| // Create a runner config | ||
| config := &session.SessionConfig{ | ||
| Agents: []agent.Agent{llmAgent}, | ||
| } | ||
|
|
||
| // Create a launcher with full capabilities | ||
| l := full.NewLauncher() | ||
|
|
||
| // Run the agent | ||
| err = l.ParseAndRun(ctx, config, os.Args[1:], nil) | ||
| if err != nil { | ||
| log.Fatalf("Failed to run: %v", err) | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test covers the primary functionality of
RequestConfirmationwell. To improve test coverage, consider adding a test case for the fallback logic inRequestConfirmationwheretoolNameis not provided during context creation. This would ensure the behavior for that edge case is tested and correct.