-
Notifications
You must be signed in to change notification settings - Fork 278
Feat/triage labelling bot #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @D-sense, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new, intelligent issue triaging and labeling bot for the ADK Go repository. By integrating with Google's Gemini model and the ADK framework, the bot automates the process of categorizing GitHub issues, assigning labels, and delegating ownership. This significantly streamlines issue management, ensuring that new issues are quickly and accurately routed to the correct teams or individuals, thereby enhancing workflow efficiency and responsiveness. Highlights
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a new triaging and labeling bot, which is a great addition. The implementation is solid, but I've found a few areas for improvement, including a critical bug in handling API responses, a configuration mismatch in the documentation that would break the GitHub Action, and several opportunities to enhance code robustness, configurability, and maintainability. Please see my detailed comments.
| labelToOwner = map[string]string{ | ||
| "agent engine": "yeesian", | ||
| "documentation": "polong-lin", | ||
| "services": "DeanChensj", | ||
| "question": "", | ||
| "mcp": "seanzhou1023", | ||
| "tools": "seanzhou1023", | ||
| "eval": "ankursharmas", | ||
| "live": "hangfei", | ||
| "models": "genquan9", | ||
| "tracing": "jawoszek", | ||
| "core": "Jacksunwei", | ||
| "web": "wyf7107", | ||
| "a2a": "seanzhou1023", | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we keeping the same list for those?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The list will be different. Something we need to agree on first internally.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@karolpiotrowicz that sounds very good! Once you have a decision/conclusion I would update it.
6caadae to
08816ba
Compare
…n Go using the ADK framework. It automatically analyzes GitHub issues and assigns appropriate labels and owners based on the issue content Add README.md file Add unit tests Address gemini-code-assist reviews
edef1b8 to
f2530ce
Compare
|
This is good for a review when someone gets a chance. |
This PR adds an automatic issue triaging and labeling bot for the ADK Go repository, implemented in Go using the ADK framework.
It automatically analyzes GitHub issues and assigns appropriate labels and owners based on the issue content.
Issue Number: #287