Skip to content

Conversation

@nktks
Copy link

@nktks nktks commented Nov 14, 2025

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @nktks, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request integrates the Vertex AI RAG (Retrieval-Augmented Generation) Engine tool into the adk-go framework, enabling agents to perform Retrieval-Augmented Generation by querying specified RAG corpora. The changes introduce a new VertexAIRAG tool that configures LLM requests to utilize Vertex AI's built-in RAG capabilities, specifically for Gemini models. An accompanying example demonstrates its usage, and dedicated tests ensure its proper functioning.

Highlights

  • Vertex AI RAG Tool Integration: Introduces the VertexAIRAG tool for Retrieval-Augmented Generation using Vertex AI, enabling agents to leverage external knowledge bases.
  • Built-in RAG Support: The implementation specifically utilizes the built-in Vertex AI RAG tool for Gemini models, intentionally omitting older Gemini 1.x functional tool support due to its retirement.
  • New Example for Usage: Adds a new example file, examples/tools/retrievaltool/main.go, which demonstrates how to configure and use the VertexAIRAG tool within an llmagent.
  • Core Tool Implementation: Defines the VertexAIRAG struct and its ProcessRequest method in tool/retrievaltool/vertex_ai_rag.go, responsible for injecting the RAG configuration into LLM requests.
  • Comprehensive Testing: Includes tool/retrievaltool/vertex_ai_rag_test.go to validate the correct integration and functionality of the VertexAIRAG tool, ensuring it properly modifies LLM requests.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new retrieval tool for Vertex AI RAG, along with an example and tests. The core implementation is clean and follows the existing tool pattern. My review focuses on improving the reusability of the example code and enhancing the thoroughness of the tests. I've suggested making configuration parameters in the example readable from environment variables and expanding test coverage to include all fields of the RAG configuration. I also found and suggested a fix for a potential panic in the new test case.

nktks and others added 6 commits November 14, 2025 20:58
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant