-
Notifications
You must be signed in to change notification settings - Fork 278
Update issue templates #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @dpasiukevich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces standardized issue templates for bug reports and feature requests. The primary goal is to enhance the quality and consistency of submitted issues by providing clear structures and prompts for necessary information. This will help maintainers and contributors efficiently understand and address incoming reports and suggestions, ultimately streamlining the project's issue management workflow. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces issue templates for bug reports and feature requests. The templates are well-structured and will help standardize issue submissions. I've made a couple of minor suggestions in the bug report template to fix a typo and a formatting inconsistency to improve clarity and professionalism. The feature request template looks good.
Correct formatting of model information section.
kdroste-google
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider more "structured" approach
| --- | ||
|
|
||
| ** Please make sure you read the contribution guide and file the issues in the right place. ** | ||
| [Contribution guide.](https://google.github.io/adk-docs/contributing-guide/) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing Go-specific entries in https://google.github.io/adk-docs/contributing-guide/ :
https://google.github.io/adk-docs/contributing-guide/#reporting-issues-bugs-errors
https://google.github.io/adk-docs/contributing-guide/#suggesting-enhancements
https://google.github.io/adk-docs/contributing-guide/#improving-documentation
https://google.github.io/adk-docs/contributing-guide/#writing-code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it's a separate repo which will be handled in a separate PR.
| title: '' | ||
| labels: bug | ||
| assignees: '' | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would be better to add some structure
See
https://github.com/google/gvisor/blob/master/.github/ISSUE_TEMPLATE/bug_report.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please open https://github.com/google/gvisor/issues and create a new issue
| [Contribution guide.](https://google.github.io/adk-docs/contributing-guide/) | ||
|
|
||
| **Is your feature request related to a problem? Please describe.** | ||
| A clear and concise description of what the problem is. Ex. I'm always frustrated when [...] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I always wanted to do .... instead of frustrated ? :)
| ** Please make sure you read the contribution guide and file the issues in the right place. ** | ||
| [Contribution guide.](https://google.github.io/adk-docs/contributing-guide/) | ||
|
|
||
| **Is your feature request related to a problem? Please describe.** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add relations to bugs
|
|
||
| **To Reproduce** | ||
| Please share a minimal code and data to reproduce your problem. | ||
| Steps to reproduce the behavior: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't apply for docs issues, maybe we should have a dedicated one for that
Or we can add "other issues" for docs, questions, debt etc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it exists by default. When issue is created you could either choose from the templates OR create a blank issue which is exactly for that.

No description provided.