Description
The current implementation of MutableMultiplePermissionsState.shouldShowRationale does not consider cases where one or more permissions are Denied(shouldShowRationale=false). This causes issues in statements such as
val permissions = rememberMultiplePermissionsState(listOf(ACCESS_FINE_LOCATION, ACCESS_BACKGROUND_LOCATION))
when {
// Granted
permissions.allPermissionsGranted -> Unit,
// Denied, but I can ask the user
permissions.shouldShowRationale ->
// ERROR: Does not trigger!
permissions.launchMultiplePermissionRequest()
// Denied and I may not ask the user.
else -> Unit
}The issue is located at
|
permissions.any { it.status.shouldShowRationale } |
Suggested fix:
override val shouldShowRationale: Boolean by derivedStateOf {
- permissions.any { it.status.shouldShowRationale }
+ permissions.any { it.status.shouldShowRationale } && permissions.none { !it.status.isGranted && !it.status.shouldShowRationale }
}
Description
The current implementation of
MutableMultiplePermissionsState.shouldShowRationaledoes not consider cases where one or more permissions areDenied(shouldShowRationale=false). This causes issues in statements such asThe issue is located at
accompanist/permissions/src/main/java/com/google/accompanist/permissions/MutableMultiplePermissionsState.kt
Line 130 in 57907e1
Suggested fix:
override val shouldShowRationale: Boolean by derivedStateOf { - permissions.any { it.status.shouldShowRationale } + permissions.any { it.status.shouldShowRationale } && permissions.none { !it.status.isGranted && !it.status.shouldShowRationale } }