[RVV] rework rvv qs8-gemm/qs8-igemm generators#9639
Open
ken-unger wants to merge 3 commits intogoogle:masterfrom
Open
[RVV] rework rvv qs8-gemm/qs8-igemm generators#9639ken-unger wants to merge 3 commits intogoogle:masterfrom
ken-unger wants to merge 3 commits intogoogle:masterfrom
Conversation
ken-unger
commented
Mar 7, 2026
| @@ -4,31 +4,40 @@ | |||
| // This source code is licensed under the BSD-style license found in the | |||
Contributor
Author
There was a problem hiding this comment.
The primary change in this PR is this file and the qs8-igemm version.
- use the output datatype as the LMUL (and reflected in the filename)
- use overloaded intrinsics where possible, which is a lot cleaner
- add QU8, QC4_F32, QC4_F16
- other cleanup
ken-unger
commented
Mar 7, 2026
| "f32": "float", | ||
| }[input_datatype] | ||
| ) | ||
| nr_type = { |
Contributor
Author
There was a problem hiding this comment.
this change (rvv specific) is paired with the change to the qs8-gemm/igemm generator. Makes more sense now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A large PR but a small number of notable changes. Primarily this is a rework of the rvv qs8-gemm and qs8-igemm generators to clean up past sins and prep for future updates.
Tested on qemu-riscv64 and bpi-f3. (I'll submit a separate PR for the qemu option used for rvv fp16)
In future, qc2w and other variants will be added. Additionally, I hope to add support for vqdot.[vv,vx], although likely using a separate generator.