Fix BF16 dot emulation for dynamic B#9595
Open
copybara-service[bot] wants to merge 1 commit intomasterfrom
Open
Fix BF16 dot emulation for dynamic B#9595copybara-service[bot] wants to merge 1 commit intomasterfrom
copybara-service[bot] wants to merge 1 commit intomasterfrom
Conversation
When `input_c_id` to a dot operator is `YNN_INVALID_VALUE_ID`, we would do this: ``` return dot(a_bf16, b_bf16, residual) ``` Instead of: ``` ab = dot(a_bf16, b_bf16, input_c_id) return add(ab, residual) ``` However this does not work when B is dynamic as the initializer to the dot is not expected to be dynamic. This CL updates code to use dot + add. PiperOrigin-RevId: 875083836
copybara-service
bot
force-pushed
the
test_875083836
branch
from
0241db5 to
2d17103
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix BF16 dot emulation for dynamic B
When
input_c_idto a dot operator isYNN_INVALID_VALUE_ID, we would do this:Instead of:
However this does not work when B is dynamic as the initializer to the dot is not expected to be dynamic.
This CL updates code to use dot + add.