Update //bench:convolution_bench and //bench:deconvolution_bench to properly flush the L2 caches between runs and use the num_threads and benchmark_min_iters flags.
#7797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test_725129452
branch
from
8651d51 to
0823d8b
Compare
copybara-service
bot
changed the title
//bench:convolution_bench to properly flush the L2 caches between runs and use the num_threads and benchmark_min_iters flags.//bench:convolution_bench and //bench:deconvolution_bench to properly flush the L2 caches between runs and use the num_threads and benchmark_min_iters flags.
copybara-service
bot
force-pushed
the
test_725129452
branch
2 times, most recently
from
12c4ee5 to
167df02
Compare
copybara-service
bot
force-pushed
the
test_725129452
branch
from
167df02 to
1c8991b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update
//bench:convolution_benchand//bench:deconvolution_benchto properly flush the L2 caches between runs and use thenum_threadsandbenchmark_min_itersflags.This also fixes an occasional segfault due to not aligning the
workspacepointer.