Skip to content

Guard packed weights size against integer overflow in batch matrix multiply #10842

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Jul 24, 2026
Merged

Guard packed weights size against integer overflow in batch matrix multiply #10842

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion src/operators/batch-matrix-multiply-nc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,7 +439,14 @@ XNN_NO_SANITIZE_FUNCTION enum xnn_status create_batch_matrix_multiply_nc_const_w
const uint32_t nr =
batch_matrix_multiply_op->ukernel.gemm_ukernels->gemm.nr;
const size_t n_stride = round_up(n, nr);
const size_t packed_size = batch_size_b * n_stride * weights_stride;
size_t packed_size;
if (!xnn_safe_mul(batch_size_b, n_stride, &packed_size) ||
!xnn_safe_mul(packed_size, weights_stride, &packed_size)) {
xnn_log_error(
"failed to create %s operator: packed weights size overflows size_t",
xnn_operator_type_to_string_v2(batch_matrix_multiply_op));
return xnn_status_out_of_memory;
}
const size_t aligned_size =
round_up_po2(packed_size, XNN_ALLOCATION_ALIGNMENT);

Expand Down