[DNM] Investigate macOS keychain issue #74
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The |
ncooke3
commented
Aug 15, 2022
Comment on lines
+178
to
+274
| #pragma mark - Version Compatibility | ||
|
|
||
| - (void)FAILS_testVersionCompatibility_GetObject { | ||
| // Given | ||
| // - Object is set with old implementation. | ||
| id oldMockCache = OCMPartialMock([[NSCache alloc] init]); | ||
| GULKeychainStorageV7_7_0 *oldKeychainStorage = | ||
| [[GULKeychainStorageV7_7_0 alloc] initWithService:kKeychainServiceName cache:oldMockCache]; | ||
|
|
||
| [self assertSuccessWriteObject:@100 | ||
| forKey:@"test-key1" | ||
| toStorage:(GULKeychainStorage *)oldKeychainStorage | ||
| withMockCache:oldMockCache]; | ||
|
|
||
| // When | ||
| // - App is updated to include a Google Utilities version greater than 7.7.0. | ||
|
|
||
| // Then | ||
| // - Object is retrieved with new implementation. | ||
| [self.mockCache removeAllObjects]; | ||
| [self assertSuccessReadObject:@100 | ||
| forKey:@"test-key1" | ||
| class:[NSNumber class] | ||
| existsInCache:YES | ||
| fromStorage:self.storage | ||
| withMockCache:self.mockCache]; | ||
| } | ||
|
|
||
| - (void)testVersionCompatibility_SetObject { | ||
| // Given | ||
| // - Object is set with old implementation. | ||
| id oldMockCache = OCMPartialMock([[NSCache alloc] init]); | ||
| GULKeychainStorageV7_7_0 *oldKeychainStorage = | ||
| [[GULKeychainStorageV7_7_0 alloc] initWithService:kKeychainServiceName cache:oldMockCache]; | ||
|
|
||
| [self assertSuccessWriteObject:@100 | ||
| forKey:@"test-key1" | ||
| toStorage:(GULKeychainStorage *)oldKeychainStorage | ||
| withMockCache:oldMockCache]; | ||
|
|
||
| // When | ||
| // - App is updated to include a Google Utilities version greater than 7.7.0. | ||
|
|
||
| // Then | ||
| // - The same object is updated with new implementation. | ||
| [self assertSuccessWriteObject:@200 | ||
| forKey:@"test-key1" | ||
| toStorage:self.storage | ||
| withMockCache:self.mockCache]; | ||
|
|
||
| [self assertSuccessReadObject:@200 | ||
| forKey:@"test-key1" | ||
| class:[NSNumber class] | ||
| existsInCache:YES | ||
| fromStorage:self.storage | ||
| withMockCache:self.mockCache]; | ||
|
|
||
| [oldMockCache removeAllObjects]; | ||
| [self assertSuccessReadObject:@200 | ||
| forKey:@"test-key1" | ||
| class:[NSNumber class] | ||
| existsInCache:NO | ||
| fromStorage:(GULKeychainStorage *)oldKeychainStorage | ||
| withMockCache:oldMockCache]; | ||
| } | ||
|
|
||
| - (void)FAILS_testVersionCompatibility_RemoveObject { | ||
| // Given | ||
| // - Object is set with old implementation. | ||
| [self assertNonExistingObjectForKey:@"test-key1" class:[NSNumber class]]; | ||
|
|
||
| id oldMockCache = OCMPartialMock([[NSCache alloc] init]); | ||
| GULKeychainStorageV7_7_0 *oldKeychainStorage = | ||
| [[GULKeychainStorageV7_7_0 alloc] initWithService:kKeychainServiceName cache:oldMockCache]; | ||
|
|
||
| [self assertSuccessWriteObject:@100 | ||
| forKey:@"test-key1" | ||
| toStorage:(GULKeychainStorage *)oldKeychainStorage | ||
| withMockCache:oldMockCache]; | ||
|
|
||
| // When | ||
| // - App is updated to include a Google Utilities version greater than 7.7.0. | ||
|
|
||
| // Then | ||
| // - The same object is removed with new implementation. | ||
| [self assertRemoveObjectForKey:@"test-key1"]; | ||
|
|
||
| // The below assertion should not pass but does. | ||
| [oldMockCache removeAllObjects]; | ||
| [self assertSuccessReadObject:@100 | ||
| forKey:@"test-key1" | ||
| class:[NSNumber class] | ||
| existsInCache:NO | ||
| fromStorage:(GULKeychainStorage *)oldKeychainStorage | ||
| withMockCache:oldMockCache]; | ||
| } | ||
|
|
There was a problem hiding this comment.
There are three cases to check for version compatibility. The first and third tests are prefixed with FAILS_ as they fail locally. The other case passes.
The failures indicate two things:
- that when apps upgrade to the new implementation, they will not be able to receive any data that was stored with the previous implementation.
- that when apps upgrade to the new implementation, they will not be able to remove any data that was stored with the previous implementation.
ncooke3
commented
Aug 19, 2022
Comment on lines
+182
to
+184
| if (@available(iOS 13.0, macOS 10.15, macCatalyst 13.0, tvOS 13.0, watchOS 6.0, *)) { | ||
| query[(__bridge id)kSecUseDataProtectionKeychain] = (__bridge id)kCFBooleanTrue; | ||
| } |
There was a problem hiding this comment.
This is the necessary code to resolve the issue.
|
Actual fix is in #75 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#no-changelog