Conversation
mdmathias
force-pushed
the
mdmathias/swift-sample-app
branch
from
d638465 to
6b42b34
Compare
petea
reviewed
Oct 29, 2021
Contributor
petea
left a comment
petea
left a comment
There was a problem hiding this comment.
Branding
Let's come up with a fun app name to replace GSI-Swift-Sample. We were kicking around a few of these already... BirthdayParty, BirthdayCountdown, BirthdayCheck?
Packaging
We'll want to demonstrate CocoaPods as well as SPM dependency management. We could add a CocoaPods specific project and Podfile for the new app as we've done for the existing sample.
Directory Structure
Consider the following layout...
Samples/Objc/SignInSample/.xcodeproj
Samples/Swift/SAMPLE_APP_NAME/.xcodeproj
Might be nice to avoid having a duplicate level inside SAMPLE_APP_NAME/ as with the current GSI-Swift-Sample/GSI-Swift-Sample/
Samples/Swift/GSI-Swift-Sample/GSI-Swift-Sample.xcodeproj/project.pbxproj
Show resolved
Hide resolved
mdmathias
force-pushed
the
mdmathias/swift-sample-app
branch
from
1dde75f to
0f84a64
Compare
mdmathias
force-pushed
the
mdmathias/swift-sample-app
branch
from
ece2d6a to
5e6695d
Compare
petea
reviewed
Nov 3, 2021
mdmathias
force-pushed
the
mdmathias/swift-sample-app
branch
2 times, most recently
from
98db3bc to
75a120d
Compare
mdmathias
force-pushed
the
mdmathias/swift-sample-app
branch
from
75a120d to
9ecb6f5
Compare
petea
reviewed
Nov 16, 2021
petea
approved these changes
Nov 16, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds a sample app demonstrating the use of GoogleSignIn-iOS in SwiftUI.