Skip to content

Always generate a clang module.#53

Merged
petea merged 3 commits intomainfrom
petea-module
Aug 20, 2021
Merged

Always generate a clang module.#53
petea merged 3 commits intomainfrom
petea-module

Conversation

@petea
Copy link
Contributor

@petea petea commented Aug 19, 2021

Allow CocoaPods developers to use modules without requiring that use_frameworks! or :modular_headers => true be used their Podfile.

Resolves #32 and #33.

@petea petea requested a review from paulb777 August 19, 2021 23:31
Copy link
Member

@paulb777 paulb777 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I recommend adding two more pod lib lint commands to the CI yml file to make sure other library/module variations continue to build. With the option --use-libraries and the option --use-static-frameworks

@petea petea merged commit d8409b7 into main Aug 20, 2021
@petea petea deleted the petea-module branch August 20, 2021 22:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GoogleSignIn does not define a clang module, cannot @import GoogleSignIn when built as a library

3 participants