You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This change makes it so that GoogleSignInSwiftSupport.podspec depends upon v7.1.0 (and up) on CocoaPods instead of "7.1.0-fac-beta-1.1.0". This helps to avoid needing to release a new version of GoogleSignInSwiftSupport on CocoaPods, which would be required if we changed GoogleSignInSwiftSupport's GSI dependency version.
GoogleSignInSwiftSupport.podspec fails to lint because that podspec lists its dependency on GSI as s.dependency 'GoogleSignIn', '~> 7.1'. Yet, the lint command is
pod lib lint GoogleSignInSwiftSupport.podspec --verbose --no-clean \
--sources=https://cdn.cocoapods.org/ \
--include-podspecs='GoogleSignIn.podspec'
This will try to use the local GoogleSignIn.podspec for the Swift Support's podspec dependency. GSI's version in the local podspec is '7.1.0-fac-beta-1.1.0'. Thus, the linting fails with the error:
-> GoogleSignInSwiftSupport (7.1.0)
- ERROR | [iOS] unknown: Encountered an unknown error (CocoaPods could not find compatible versions for pod "GoogleSignIn":
In Podfile:
GoogleSignIn (from `.`)
Essentially, the lint command is saying to use the local GoogleSignIn.podspec to satisfy GoogleSignInSwiftSupport.podspec's dependency on GSI, but the linting fails because the versions do not match.
If I remove using the local GoogleSignIn.podspec from the lint command, then linting will use GSI v7.1.0 (published on cocoapods.org) to satisfy GoogleSignInSwiftSupport.podspec's dependency. The command below passes locally:
pod lib lint GoogleSignInSwiftSupport.podspec --verbose \
--sources=https://cdn.cocoapods.org
Thus, I think this is fine to merge as is. We want GoogleSignInSwiftSupport.podspec to depend upon GSI v7.1.0 to avoid making a new release for the Swift Support pod. Additionally, "7.1.0-fac-beta-1.1.0" will be a published version of GSI upon release. This means future pod lib lints won't fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes it so that
GoogleSignInSwiftSupport.podspecdepends upon v7.1.0 (and up) on CocoaPods instead of"7.1.0-fac-beta-1.1.0". This helps to avoid needing to release a new version ofGoogleSignInSwiftSupporton CocoaPods, which would be required if we changedGoogleSignInSwiftSupport's GSI dependency version.SKIP_INTEGRATION_TESTS=YES