Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap 'with' for 'for' in method parameter names #218

Merged
merged 2 commits into from
Jan 14, 2023
Merged

Swap 'with' for 'for' in method parameter names #218

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4208fca
Swap 'with' for 'for' in method parameter names
mdmathias Jan 13, 2023
090f497
Update @objc name
mdmathias Jan 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Update @objc name
  • Loading branch information
@mdmathias
mdmathias committed Jan 13, 2023
commit 090f497fe9c173cfff877d5459eec3d17b13b4c5
2 changes: 1 addition & 1 deletion GTMAppAuth/Sources/KeychainStore/KeychainStore.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ extension KeychainStore: AuthSessionStore {
)
}

@objc(saveAuthSession:forItemName:error:)
@objc(saveAuthSession:withItemName:error:)
public func save(authSession: AuthSession, withItemName itemName: String) throws {
let authSessionData = try authSessionData(fromAuthSession: authSession)
try keychainHelper.setPassword(
Expand Down
8 changes: 4 additions & 4 deletions GTMAppAuth/Tests/ObjCIntegration/KeychainStore/GTMKeychainStoreTests.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ - (void)testSavingWithNewItemName {

NSError *error;
[self.keychainStore saveAuthSession:self.authSession
forItemName:newItemName
withItemName:newItemName
error:&error];
XCTAssertNil(error);

Expand All @@ -112,7 +112,7 @@ - (void)testSavingWithCustomItemName {
NSError *error;

[self.keychainStore saveAuthSession:self.authSession
forItemName:customItemName
withItemName:customItemName
error:&error];
XCTAssertNil(error);

Expand All @@ -134,7 +134,7 @@ - (void)testSavingWithCustomItemName {
- (void)testSaveAuthSessionErrorNoServiceName {
NSError *error;
[self.keychainStore saveAuthSession:self.authSession
forItemName:@""
withItemName:@""
error:&error];
XCTAssertNotNil(error);
XCTAssertEqualObjects(error.domain, @"GTMAppAuthKeychainErrorDomain");
Expand Down Expand Up @@ -172,7 +172,7 @@ - (void)testRetrieveAuthSessionForCustomItemName {
NSError *error;
NSString *customItemName = @"customItemName";
self.keychainStore.itemName = customItemName;
[self.keychainStore saveAuthSession:self.authSession forItemName:customItemName error:&error];
[self.keychainStore saveAuthSession:self.authSession withItemName:customItemName error:&error];
XCTAssertNil(error);

GTMAuthSession *retrievedAuthSession =
Expand Down