Unify GTMKeychain implementations #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdmathias
approved these changes
Apr 29, 2022
Alex-4-Git
reviewed
Apr 29, 2022
lksoft
added a commit
to Smallcubed/GTMAppAuth
that referenced
this pull request
Aug 18, 2022
* g-master: Bump tzinfo from 1.2.9 to 1.2.10 (google#165) Allow use of GTMSessionFetcher 2.x versions. (google#155) Prep the 1.3.0 release (google#152) Create SPM projects for the example apps (google#153) Allow developers to use the data protection keychain on macOS (google#151) Unify GTMKeychain implementations (google#150) Update example apps (google#149) Update Example-macOS Podfile (google#147) Bump cocoapods-downloader from 1.4.0 to 1.6.3 (google#146) Prep for 1.2.3 release (google#144) Match GTMSessionFetcher's min macOS version to avoid warnings. (google#142) Add SPM tests. (google#143) Handle errSecDuplicateItem in savePassword on macOS (google#138) Bump addressable from 2.7.0 to 2.8.0 (google#133) # Conflicts: # Package.swift
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using a lightly modified version of GTMKeychain_iOS for all platforms, doing away with GTMKeychain_macOS which used the legacy Keychain API. This opens the door to using kSecUseDataProtectionKeychain on macOS.
In order to allow the unified GTMKeychain implementation to read existing keychain items created by GTMKeychain_macOS, we will stop setting and querying for kSecAttrGeneric which is unavailable to the legacy Keychain API and not needed for our use case.